#5823 closed defect (fixed)
API3 handles 0/false values from template incorrect
| Reported by: | Silier | Owned by: | |
|---|---|---|---|
| Priority: | Must Have | Milestone: | Alpha 24 |
| Component: | AI | Keywords: | simple |
| Cc: | Patch: | Phab:D3010 |
Description
https://code.wildfiregames.com/source/0ad/browse/ps/trunk/binaries/data/mods/public/simulation/ai/common-api/entity.js$36 needs to check for undefined
if (value[arg])
Reported by Teiresias
Found by smiley
Forum link: https://wildfiregames.com/forum/topic/29206-questions-on-ai-api3-template-handling/
Change History (2)
comment:1 by , 4 years ago
| Keywords: | simple added |
|---|---|
| Patch: | simple → Phab:D3010 |
comment:2 by , 4 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
In r24053:
[Petra/AI]Handle 0 case for template parsing
[Petra]Check against undefined when caching variables from templates.
Current check does not allow to read 0 and false values from templates and represents them as undefined.
Forum link: https://wildfiregames.com/forum/topic/29206-questions-on-ai-api3-template-handling/
Reported by: Teiresias
Patch by: smiley
Reviewed by: Angen
Differential Revision: D3010