Opened 3 years ago

Closed 3 years ago

#5863 closed defect (fixed)

Command group camera move does not work if one of the units in the group are garrisoned

Reported by: Alistair_Findlay Owned by: Freagarach
Priority: Should Have Milestone: Alpha 26
Component: UI – In-game Keywords: simple
Cc: Patch: Phab:D4242

Description

Double press on building command group moves the camera to those grouped units, but it doesn't work if any of the units in that group are garrisoned.

When double pressing the key for a command group, when that function is deciding where to put the camera it should ignore if any of the grouped units are garrisoned.

Change History (6)

comment:1 by Freagarach, 3 years ago

Component: Core engineUI – In-game

Note that this only happens when the first entity in the group is garrisoned (the one with the lowest entity ID) since that is what the code uses to focus on. It would indeed be nice to just focus on the next possible entity.

Although one could also say we need to focus on the building the entity is garrisoned in?

comment:2 by Freagarach, 3 years ago

Keywords: simple added
Milestone: BacklogAlpha 26

Either of the two above mentioned possibilities is fairly easy to implement.

comment:3 by Silier, 3 years ago

Keywords: simple removed
severity: simple

comment:4 by Silier, 3 years ago

Keywords: simple added

comment:5 by Freagarach, 3 years ago

Owner: set to Freagarach
Patch: Phab:D4242

comment:6 by Freagarach, 3 years ago

Resolution: fixed
Status: newclosed

In 25893:

Move camera to holder when moving to grouped units.

Instead of doing nothing.

Differential revision: https://code.wildfiregames.com/D4242
Reviewed by: @bb
Fixes: #5863
Comment by: @Langbart

Note: See TracTickets for help on using tickets.