Opened 3 years ago

Last modified 10 months ago

#5894 new enhancement

Split Player.js component.

Reported by: Freagarach Owned by:
Priority: If Time Permits Milestone: Alpha 27
Component: Simulation Keywords:
Cc: Patch: ​Phab:D4473, ​Phab:D4921

Description

To me at least, it seems that cmpPlayer could be cleaned a bit by separating some stuff into separate components. E.g. Diplomacy, Inventory, Population. Perhaps even more, or one of these not.

Change History (7)

comment:1 by Stan, 3 years ago

Milestone: Alpha 25 → Alpha 26

comment:2 by Freagarach, 2 years ago

Patch: → Phab:D4473

GenericName, History, Icon -> cmpIdentity: ​Phab:D4473.

comment:3 by Stan, 2 years ago

Milestone: Alpha 26 → Alpha 27

Unlikely to get done for A26

comment:4 by Freagarach, 16 months ago

Milestone: Alpha 27 → Backlog

Pushing back.

comment:5 by Freagarach, 15 months ago

Milestone: Backlog → Alpha 28
Patch: Phab:D4473 → Phab:D4473, Phab:D4921

[26298]

​Phab:D4921 for Diplomacy.

comment:6 by Stan, 11 months ago

Milestone: Alpha 28 → Alpha 27

Push back

comment:7 by Freagarach, 10 months ago

In 27722:

Pull Diplomacy out of cmpPlayer.

Who says only players should be able to conduct diplomacy?
Also separation of concerns, more maintainable files.

Differential revision: ​https://code.wildfiregames.com/D4921
Comments by: @elexis, @Stan
Refs. #5894

Note: See TracTickets for help on using tickets.