Opened 2 years ago

Closed 2 years ago

#5908 closed defect (fixed)

Serialization symbol cannot be written on object ({attack:["Unit", "Structure"]}) rP24551

Reported by: Silier Owned by: wraitii
Priority: Release Blocker Milestone: Alpha 24
Component: Simulation Keywords:
Cc: wraitii Patch: Phab:D3334 Phab:D3336

Description (last modified by Silier)

It happens after using attack-move replay with D3225

Attachments (1) (156.8 KB ) - added by Silier 2 years ago.

Download all attachments as: .zip

Change History (6)

by Silier, 2 years ago

Attachment: added

comment:1 by Silier, 2 years ago

Cc: wraitii added

possible causes rP24462 or rP24167

comment:2 by Silier, 2 years ago

Description: modified (diff)

comment:3 by Silier, 2 years ago

Description: modified (diff)

comment:4 by wraitii, 2 years ago

Owner: set to wraitii
Patch: Phab:D3334 Phab:D3336

Fixed by both D3334 and D3336 in different ways.

comment:5 by wraitii, 2 years ago

Resolution: fixed
Status: newclosed

In 24563:

Revert rP24167 / Keep track of serialized objects using a GCHashTable

This reverts rP24167. That diff had two issues:

  • It modifies the JS objects, which means subsequent serialization in quicksave are 'dirty'.
  • It doesn't work with non-extensible objects. That's rather annoying, and has already caused problems.

It also revert rP24466, which was necessary because of the second issue.

Fixes #5908

Differential Revision:

Note: See TracTickets for help on using tickets.