Opened 3 years ago

Closed 3 years ago

#5909 closed defect (fixed)

Replays OOS

Reported by: Silier Owned by: wraitii
Priority: Release Blocker Milestone: Alpha 24
Component: Core engine Keywords:
Cc: Patch:

Description

In game from #5908, by the end of the match I had garrisoned fortress by few rams and champion swordsmen, also I had fully build arsenal so commands are missing in replay. There was no oos in game, so or there is silent oos in live match or replays are bugged.

Attachments (5)

commands.txt (297.9 KB ) - added by Freagarach 3 years ago.
My replay.
commands.2.txt (484.1 KB ) - added by Feldfeld 3 years ago.
Yesterday's multiplayer game
commands.3.txt (300.8 KB ) - added by Feldfeld 3 years ago.
An OOS on viewing replay I got today (rP24640)
commands.4.txt (1.2 MB ) - added by Feldfeld 3 years ago.
commands.5.txt (332.7 KB ) - added by wraitii 3 years ago.
OOS in visual replay only, revs rP24756-rP24763 (all those should be compatible)

Change History (9)

by Freagarach, 3 years ago

Attachment: commands.txt added

My replay.

comment:1 by wraitii, 3 years ago

Replaying on Phab:rP24551 + Phab:D3225 I get an OOS on turn 1481 when the Player 2 (Angen) dogs are ordered to attack.

Both of your replay and Freagarach's agree on the hashes.

I don't really see how replays could be bugged _in general_ here, a I would expect it to fail much earlier... This is quite intriguing...

by Feldfeld, 3 years ago

Attachment: commands.2.txt added

Yesterday's multiplayer game

by Feldfeld, 3 years ago

Attachment: commands.3.txt added

An OOS on viewing replay I got today (rP24640)

comment:2 by wraitii, 3 years ago

I'm not getting an OOS with commands.3.txt

Are you using the windows autobuild? If so you probably want rP24642, which contains rP24610, which fixes such an issue.

by Feldfeld, 3 years ago

Attachment: commands.4.txt added

comment:3 by wraitii, 3 years ago

I'm not getting an OOS when replaying that on rP24650

by wraitii, 3 years ago

Attachment: commands.5.txt added

OOS in visual replay only, revs rP24756-rP24763 (all those should be compatible)

comment:4 by wraitii, 3 years ago

Owner: set to wraitii
Resolution: fixed
Status: newclosed

In 24764:

Revert rP24280, causing false OOS in visual replays.

rP24280 fixed #5546, but it seems to cause some rare OOS in visual replays, as reported in #5909. The culprit is likely that hashes aren't computed at quite the same moment and onDestroy changes things.

Reverting for now before A24.

Reported by: Angen

Refs #5546.
Fixes #5909

Note: See TracTickets for help on using tickets.