Opened 3 years ago

Closed 3 years ago

#5921 closed defect (fixed)

blank lines in chat

Reported by: Imarok Owned by: s0600204
Priority: Release Blocker Milestone: Alpha 24
Component: UI – In-game Keywords:
Cc: Patch:

Description

Sometimes blank lines occur in the chat and also in the chat history.

I could reproduce it with user1:

1v1 game I vs AI. user1 was observer and watched the AI when I started researching the next phase user1 got a blank line instead of "Imarok is advancing to Town Phase."

I could not reproduce the issue when trying again with two local instances of 0ad.

Change History (2)

comment:1 by Stan, 3 years ago

I did get a few blank lines during yesterday's match. I'm on windows so I cannot run two instances of the game, but is it possible that the observer needs to be watching a player for that to occur?

comment:2 by s0600204, 3 years ago

Owner: set to s0600204
Resolution: fixed
Status: newclosed

In 24671:

Improve detection of empty notification messages

In the case that a player started or aborted researching a phase technology, a
blank line was being added to the chat history of the player in question and
any mutual ally or observer, where the player, ally, or observer had their
gui.session.notifications.phase setting at the default value of "completed".

This was happening because in the above case the returned value of
ChatMessageFormatSimulation.phase class's .parse() method is {text: ""}.

Related r24565
Fixes #5921

Note: See TracTickets for help on using tickets.