OpenAL errors on macOS during replays

[Langbart]

OpenAL errors no longer appear during the game (see #5265), but they sometimes show up in replays. There doesn't seem to be a hard and fast rule to reproduce it. I will update this ticket if it happens again and I see a pattern. I will attach 3 files:

• 24781interestinglog.html
• 24781mainlog.html
• 24781system_info.txt

Typical error reported in #5265

ERROR: could not initialize ogg data at audio/interface/ui/ui_button_click.ogg
ERROR: Failed to create initial buffer. OpenAL error: Invalid Value

Typical error in replay #5978

ERROR: OpenAL error: Unknown Internal Error; called from IdleTask (line 59)

[Langbart]

I am able to generate openAL errors with the following settings.\

• SVN version: 24852
• Settings: Default
• MacOS: 10.15.7
• Replay: 2021-02-10_0002.zip (see attachments, it has 80800 turns)
• Replay speed: 20x fast forward
• Start the replay, move the camera to the Civic Center of 'Dubnovellaunus' (other camera settings could also produce the error, but I didn't test that).
• during the replay I had no other applications open and did not intervene or move the camera position

10 errors occurred:

• Turn 4931 - ERROR: OpenAL error: Unknown Internal Error; called from IdleTask (line 59)
• Turn 52102 - ERROR: OpenAL error: Unknown Internal Error; called from Run (line 151)
• Turn 61450 - ERROR: OpenAL error: Unknown Internal Error; called from HandleFade (line 222)
• Turn 63819 - ERROR: OpenAL error: Unknown Internal Error; called from IdleTask (line 81)
• Turn 67235 - ERROR: OpenAL error: Unknown Internal Error; called from IdleTask (line 81)
• Turn 67963 - ERROR: OpenAL error: Unknown Internal Error; called from IdleTask (line 81)
• Turn 69409 - ERROR: OpenAL error: Unknown Internal Error; called from IdleTask (line 81)
• Turn 69584 - ERROR: OpenAL error: Unknown Internal Error; called from IdleTask (line 66)
• Turn 74438 - ERROR: OpenAL error: Unknown Internal Error; called from IdleTask (line 81)
• Turn 75783 - ERROR: OpenAL error: Unknown Internal Error; called from IdleTask (line 81)

I will attach four files:

• 24852interestinglog.html
• 24852mainlog.html
• 24852system_info.txt
• 2021-02-10_0002.zip

[wraitii]

I think the issue remains in-flight buffers or something like that. Should be fixed by switching to the thread pool and GC-ing more often.