Opened 3 years ago

Last modified 23 months ago

#5983 new defect

Clean up Transform.js

Reported by: Freagarach Owned by:
Priority: Should Have Milestone: Backlog
Component: Simulation Keywords: simple
Cc: Patch:

Description

Currently the Transform.js helper does a lot of things, while it probably should do only a few:

  • Create a new entity.
  • Optionally set some values that _need_ to be set before other components.
  • Post the EntityRenamed message.
  • Destroy the old entity.

Refs. Phab:P46, #2004, #5906

Change History (5)

comment:1 by wraitii, 3 years ago

Milestone: Alpha 25Alpha 26

comment:2 by Silier, 3 years ago

Keywords: simple removed
severity: simple

comment:3 by Silier, 3 years ago

Keywords: simple added

comment:4 by bb, 2 years ago

Refs r25949

Notice that the use of the entity renamed message is not ideal in this commit. See some considerations at https://code.wildfiregames.com/P46#2074

comment:5 by Freagarach, 23 months ago

Milestone: Alpha 26Backlog
Note: See TracTickets for help on using tickets.