Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#5997 closed defect (fixed)

Break dance! Waltzing.

Reported by: Langbart Owned by: wraitii
Priority: Should Have Milestone: Alpha 24
Component: UI – In-game Keywords: waltzing
Cc: Patch: Phab:D3518 Phab:D3543

Description (last modified by Langbart)

The committed patch Phab:D3518 with changeset [24831] has made the 'waltzing' less frequent, but it is still noticeable.

The issues was first reported in the forum by wowgetoffyourcellphone. https://wildfiregames.com/forum/topic/35927-break-dance

(I have just created a ticket so that the bug will not be forgotten.)

Attachments (1)

24858.gif (570.3 KB ) - added by Langbart 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by Langbart, 3 years ago

I first used the provided save file from wowgetoffyourcellphone to test the bug. I was able to reproduce the bug using rP24830+DE. After applying the fix Phab:D3518, I thought the bug was solved, but after wowgetoffyourcellphone & gameboy reported on the forum that the bug was still occurring in the same way as no patch had been implemented, I tested again with rP24831+DE with the provided save file from wowgetoffyourcellphone and found that the "waltzing" was still occurring, but almost unnoticeable.

Now, playing, I found that the 'waltzing' still occurs as no patch has been applied. So it seems that the patch had no effect at all, but why did I get the results from the GIF (rP24831+DE) in the description?
I am confused.

Last edited 3 years ago by Langbart (previous) (diff)

comment:2 by Langbart, 3 years ago

Milestone: Alpha 25Alpha 24
Patch: D3518Phab:D3518

comment:3 by Langbart, 3 years ago

Patch: Phab:D3518Phab:D3518 Phab:D3543

comment:4 by wraitii, 3 years ago

Owner: set to wraitii
Resolution: fixed
Status: newclosed

In 24865:

Better fix for formation waltzing, revert rP24831.

rP24831 proved unsufficient to fix formation 'waltzing'. This is a better fix, which makes sure units actually try to reach their designated offset in the first place.
Further, it removes code that recalculated offsets un-necessarily, which led to an issue with "sloppy" formations such as open and closed orders.

Fixes #5997

Differential Revision: https://code.wildfiregames.com/D3543

comment:5 by Langbart, 3 years ago

Description: modified (diff)

Files should be hosted by Trac, otherwise they will not be accessible when the original provider (https://imgbb.com) dies. Changed the link and will upload the image to Trac.

by Langbart, 3 years ago

Attachment: 24858.gif added
Note: See TracTickets for help on using tickets.