Replay issues with save/ load and quicksave/ quickload

[Langbart]

This bug was first reported in the ​​​Forum by 'nwtour'. (I'm just creating the ticket so the bug will not be forgotten.)

Replay for save/ load
If you play a game against the AI and follow these steps below, the replay shows that the bot is playing, but your own units are just standing around. This bug can be reproduced for A23b. (2x replay files are generated, even though I just played the same game)

1. Menu
2. Save
3. Exit
4. Load
5. Resign
6. Press Replay

Replay for quicksave/ quickload

When you play a game against the AI and follow these steps below, the game switches into windowed mode and freezes. The entire Macbook becomes very unresponsive, even after I "Force Quit" the 0AD application. Only restarting the Macbook makes it run normally again. (log and replay folder for this crash will be attached: 0.0.24rc2-24928.zip)

1. Press SHIFT+F5 (quicksave)
2. Press SHIFT+F8 (quickload)
3. Resign
4. Press Replay

Another negative side effect of the "quicksave-quickload-replay" crash is that I have the 0.0.24rc2-24928 and the official A23b version installed. After restarting my Macbook, I wanted to test the "quicksave-quickload-replay" for the A23b version, but as soon as I start a game, errors appear on the loading screen for the A23b app. This never happened before and still happens after I uninstalled 0.0.24rc2-24928 app. I will attach the errors in the A23b_interestinglog.html file. The errors disappeared after I deleted everything from the Gamedatapath folders for macOS:

After A23b started working normally again, I was able to reproduce the "quicksave-quickload-replay" crash on A23b as well. But the game closes itself, I don't have to "force quit" the A23b version and my computer remains responsive, I don't have to restart the Macbook.

[Langbart]

log and replay folder for the crash with the 0.0.24rc2-24928 version

[Freagarach]

The issue with the replay of a loaded saved game is to be expected, since loading is currently just starting a new game with a fixed gamestate. So one needs the commands.txt from the first part and from the second part together. It can even be done manually (through a script) and out of the box support would indeed be nice. Duplicate of #4367.

The second part:

Game.cpp(146): Assertion failed: "turn == currentTurn && "You tried to replay a commands.txt file of a rejoined client. Please use the host's file.""
Assertion failed: "turn == currentTurn && "You tried to replay a commands.txt file of a rejoined client. Please use the host's file.""
Location: Game.cpp:146 (LoadVisualReplayData)

[wraitii]

See #4367

[Langbart]

So this ticket was closed because the 1st part (replay for save/load) was already reported in #4367 and the 2nd part (replay for quicksave/quickload) is just not supported.