Wood gathers go to the wrong tree

[Langbart]

I noticed a strange behavior of wood gathers. In the GIF below I create 10 spearmen in the CC and send them to a tree, two lumberjacks don't go where they are supposed to go.

I tested it with [24999] and [25000] the strange behavior can first be noticed with [25000].

[Langbart]

replay file for the issue

[Freagarach]

This behaviour is expected, since the first target, the tree, is full, so the two entities will search for trees nearest to where they are at the moment.

I think this is usually what a player wants, but I understand that not always this is the case.

[Freagarach]

I guess on user orders we want to gather near the clicked location, but on autocontinue nearest to the current location?

[Langbart]

This is annoying, was attacked from the north on my wood line and wanted to move my 30 ladies to the south, 22 ladies just keep chopping wood in the north because the tree I selected in the south only hold 8 ladies.

This will be on the list that the players will report. Inconveniently, I can click with Shift on a point near the forest line in the south and then press the desired tree.

[Freagarach]

In 25776:

Look for resources nigh the order when forced.

When tasked to gather, entities looked for resources close to their current location when the target was invalid (e.g. full).
Now on forced orders the entities will look for resources close to that order's location, when possible.

Differential revision: ​https://code.wildfiregames.com/D4146
Fixes: #6085
Reviewed by: @Imarok
Tested by: @Langbart
Comments by: @marder, @Stan, @wraitii