Changes between Initial Version and Version 1 of Ticket #6136, comment 4


Ignore:
Timestamp:
Apr 14, 2021, 2:17:07 AM (3 years ago)
Author:
nani

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6136, comment 4

    initial v1  
    1 Imho the best option would be to wait for the host reply, even if this means having to make another message to send and wait, the best would be to have the server as an agnostic proxy that only tells you if you are denied or allowed (if allowed send extra game info to join of course). That way you can have all the allow logic in the host client (hopefully implemented having c++ as the medium and the request verification handled in javascript for maximum  versatility, the handle cout be defined in gui/common/ or similar place). Imagine a player from lobby make a request to join a game, you as the host could be shown in the gui as a notification that player wants to join, you could then accept or reject it, or if as the ticket says, if is a buddy automatically accept. As for the players that want to join a pre join message could be indeed be nice to have. Having a password +  buddies sounds nice but then the problem that I stated at the ticket still exist, that is, you need to send the password to that person and pasting the password in the lobby chat make no sense.
     1Imho the best option would be to wait for the host reply, even if this means having to make another message to send, the best would be to have the server as an agnostic proxy that only tells you if you are denied or allowed (if allowed send extra game info to join of course). That way you can have all the allow logic in the host client (hopefully implemented having c++ as the medium and the request verification handled in javascript for maximum  versatility, the handle cout be defined in gui/common/ or similar place). Imagine a player from lobby make a request to join a game, you as the host could be shown in the gui as a notification that a player wants to join, you could then accept or reject it, or if as the ticket says, if is a buddy automatically accept. As for the players that want to join a pre join message could be indeed be nice to have. Having a password +  buddies sounds nice but then the problem that I stated at the ticket still exist, that is, you need to send the password to that person and pasting the password in the lobby chat makes no sense.
    22
    3 Overall, I think not sending the buddy list to the server is best to avoided. Better leave the verification handling to the host and in case of having something small to send like it could be the case of a password then that can be sent to the server.
     3Overall, I think sending the buddy list to the server is best  avoided. Better leave the verification handling to the host and in case of having something small to send like it could be the case of a password then that can be directly handled by the server.