Replay filter broken

[Langbart]

When checking the replay screen in the latest SVN version [25658], the Filter was enabled, but there were still some gray replays displayed.

I will attach the my replay folder as a zip file - 0.0.25.zip

A short discussion about the problem can be found in IRC 0ad-dev (3/Jun/21)

18:28 < Angen> Langbart: yeah, something is wrong with filter
18:29 < Angen> it sometimes does not filter some replays
18:29 < Angen> and sometimes it filters all

Edit 1: The problem probably starts with changeset [25634], but errors are displayed until it is fixed in [25651]. This means that the problem is probably related to [25634], but you can only check it with [25651] for the first time.

[Imarok]

Hmm, I can't reproduce the issue with your data. Did you have mods enabled?

[Langbart]

Replying to Imarok:

Hmm, I can't reproduce the issue with your data. Did you have mods enabled?

No, the problem is still there with the latest SVN version [25758], but the replay filter works perfectly with the ​recently released macOS bundle for A25.

PS: I used the same replay folder to test the macOS bundle and the SVN version.

[Freagarach]

It may or may not be related, but when I return from a replay it doesn't show any replays at all, unless I untick and tick the filter. r25763

[wraitii]

can't reproduce any issue.

[Imarok]

Replying to Freagarach:

It may or may not be related, but when I return from a replay it doesn't show any replays at all, unless I untick and tick the filter. r25763

I also can't reproduce that. I guess that means that you have to investigate the code :/

[Langbart]

Replying to Imarok:

I guess that means that you have to investigate the code :/

Good conversation on ​IRC 0ad-dev (11/Jul/21) between me and Stan, the problem boils down to the changes from ​changeset 25634 (2/Jun/21) with the introduction of ignoreInCompatibilityChecks.

[Langbart]

Additional observations added to the description for changeset [25633], [25634] and [25651].