Opened 3 years ago

Closed 3 years ago

#6204 closed defect (fixed)

Gamesetup bugs.

Reported by: Imarok Owned by: wraitii
Priority: Release Blocker Milestone: Alpha 25
Component: UI – Game setup Keywords:
Cc: wraitii Patch: Phab:D4092

Description (last modified by Imarok)

Bug 1: When joining as observer you still have a ready button
Reproduce:

  1. Host a gamesetup
  2. choose a random map and set to 1 player
  3. join with another client

Result:
joined client is an observer but has a ready button. When pressing that it throws this error:

ERROR: Errors executing script event "Tick"
ERROR: JavaScript error: gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientChat.js line 36
color is undefined
  colorizePlayernameByGUID@gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientChat.js:36:20
  onClientLeave@gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientConnection.js:21:24
  onPlayerAssignmentMessage@gui/gamesetup/Controllers/PlayerAssignmentsController.js:145:13
  pollPendingMessages@gui/gamesetup/NetMessages/NetMessages.js:42:13
  onTick@gui/gamesetup/SetupWindow.js:106:29
  @gui/gamesetup/SetupWindow.js:57:64

Expected: observers don't have a ready button.

Bug 2: player slots appearing out of nothing
Reproduce:

  1. Host gamesetup as player A
  2. choose a random map and set to 1 player
  3. Join with another client as player B
  4. Assign the slot of to player B

Result:
The player list is broken for player A and player B suddenly sees two player slots.
Screen of player A:

Screen of player B:

Expected:
Just swap the players.

Both bugs where probably introduced with rP25077 or rP25096.

Attachments (3)

screenshot0107.png (82.1 KB ) - added by Imarok 3 years ago.
screenshot0108.png (52.6 KB ) - added by Imarok 3 years ago.
screenshot0106.png (64.5 KB ) - added by Imarok 3 years ago.

Download all attachments as: .zip

Change History (6)

by Imarok, 3 years ago

Attachment: screenshot0107.png added

by Imarok, 3 years ago

Attachment: screenshot0108.png added

by Imarok, 3 years ago

Attachment: screenshot0106.png added

comment:1 by Imarok, 3 years ago

Description: modified (diff)

comment:2 by Imarok, 3 years ago

Patch: Phab:D4092

comment:3 by wraitii, 3 years ago

Owner: set to wraitii
Resolution: fixed
Status: newclosed

In 25699:

Fix gamesetup player assignment issue when joining

Switch some logic from C++ to JS in PREGAME for player assignments. Refs #3049

Fixes #6204

Reported by: Imarok

Tested By: Imarok

Differential Revision: https://code.wildfiregames.com/D4092

Note: See TracTickets for help on using tickets.