id,summary,reporter,owner,description,type,status,priority,milestone,component,resolution,keywords,cc,phab_field
6204,Gamesetup bugs.,Imarok,,"**Bug 1: When joining as observer you still have a ready button**\\
Reproduce:
 1. Host a gamesetup
 2. choose a random map and set to 1 player
 3. join with another client
Result:\\
joined client is an observer but has a ready button. When pressing that it throws this error:

{{{
ERROR: Errors executing script event ""Tick""
ERROR: JavaScript error: gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientChat.js line 36
color is undefined
  colorizePlayernameByGUID@gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientChat.js:36:20
  onClientLeave@gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientConnection.js:21:24
  onPlayerAssignmentMessage@gui/gamesetup/Controllers/PlayerAssignmentsController.js:145:13
  pollPendingMessages@gui/gamesetup/NetMessages/NetMessages.js:42:13
  onTick@gui/gamesetup/SetupWindow.js:106:29
  @gui/gamesetup/SetupWindow.js:57:64

}}}
Expected: observers don't have a ready button.

**Bug 2: player slots appearing out of nothing**\\
Reproduce:
 1. Host gamesetup as player `A`
 2. choose a random map and set to 1 player
 3. Join with another client as player `B`
 4. Assign the slot of to player `B`
Result:\\
The player list is broken for player A and player B suddenly sees two player slots.\\
Screen of player A:\\
[[Image(ticket:6204:screenshot0108.png)]]\\
Screen of player B:\\
[[Image(ticket:6204:screenshot0106.png)]]

Expected:\\
Just swap the players.

Both bugs where probably introduced with rP25077 or rP25096.",defect,new,Release Blocker,Alpha 25,UI – Game setup,,,wraitii,