Autoqueue issues

[wraitii]

• When the production queue is modified, the auto queue should untoggle

- Autoqueue ignore entity limits and allows training infinite heroes.

---

Depending on difficulty, a way out is deactivating the feature for now.

[wraitii]

In 25753:

Prevent ProductionQueue.AddItem for going over the entity limits / Fix autoqueue being able to train infinite heroes.

Autoqueue can ignore entity limits like Heroes, because AddItem does not check for them, only commands.js. This changes that, fixing the autoqueue.

Reported by: Player of 0AD

Tested by: langbart
Refs #6213

Differential Revision: ​https://code.wildfiregames.com/D4133

[wraitii]

RB bug fixed.

[Freagarach]

Replying to wraitii:

• When the production queue is modified, the auto queue should untoggle

That is a matter of taste. I regularly modify the queue and it would be not nice to have to enable it again thereafter, IMHO. Ideally we'd have more elaborate queue-modifying actions, like click and drag the order of items.

[wraitii]

In 25779:

Improvement to autoqueue usability

The graphical interface will show autoqueued units as 'ghost' units so the player gets immediate feedback on what's happening.
The autoqueue disengages if it runs out of resources or entity limits: this reflects that the autoqueue cannot resume on its own.

By changing the spot where the autoqueue pushes items, the autoqueue no longer 'buffers' one unit in advance, but remains very slightly less efficient than manual queuing. This also prevents cheats from leading to a ton of units accidentally being created.

Accepted By: Freagarach

Refs #6213

Differential Revision: ​https://code.wildfiregames.com/D4144

[Freagarach]

Autoqueue should be disabled when changing owner. PetraAI doesn't disable it when captured and it messes up her planning.

[Freagarach]

In 25819:

Disable autoqueue when changing ownership.

PetraAI can't cope with that and it may be a suprise for other players as well, when a captures production entity has autoqueue enabled.

Differential revision: ​https://code.wildfiregames.com/D4185
Refs: #6213

[Silier]

Is it fixed?

[Stan]

As far as I know the first part of the ticket isn't.

[Freagarach]

The second part is fixed, the first part is won't fix, IMHO. As for improvements, they are certainly possible. See e.g. #6278.