PetraAI produces too much siege and ships.

[Stan]

See ​https://wildfiregames.com/forum/topic/45178-a25-svn-version-25810-not-playable/. Probably introduced in r25584.

• She constructs a lot of siege without using it. (Uses most of it after r25826.)
• She constructs way too much ships without using them. (Fixed in r25828.)

For the first point, it seems that a lot of attack plans are present, since AttackPlan.addSiegeUnits is called quite a lot, even though Siege is constructed.

The second point was the result of ships having class Ranged and thus PetraAI training them when asked to train Ranged units. Fixed by trying to train Infantry+Ranged.

[Freagarach]

In 25826:

(Partly) Fix PetraAI building a lot of siege and not using it.

Following r25584 / rP25584.
The used classes for adding siege were wrong.

Reported in ​https://wildfiregames.com/forum/topic/45178-a25-svn-version-25810-not-playable/.
Differential revision: ​https://code.wildfiregames.com/D4184
Refs. #6250 by (partly) fixing the siege case.
Reviewed by: @Angen

[Freagarach]

Pushing the rest of te ticket back to the next cycle.

[Freagarach]

In 25828:

Fix PetraAI constructing ships as ordinary units.

Since r25584 / rP25584 PetraAI constructed many ships (and cavalry) because they have the "Ranged" class and we didn't check for "Infantry" anymore when training workers.

Basically a patch by: @Angen
Differential revision: ​https://code.wildfiregames.com/D4193
Reviewed by: @Angen
Refs. #6250 by fixing the ships case.
Fixes the concern on r25584 / rP25584.

[Freagarach]

Decreasing priority since PetraAI works as intended again. She just makes plenty of siege.

[Freagarach]

Actually fixed in the two mentioned commits. The plenty of siege is a feature. ;)

If it is found that she indeed produces too much siege equipment, we can create a ticket for that since it existed probably in earlier alphas already. I'm closing this as fixed since the points mentioned and fixed were caused by r25584.