Error when viewing a replay following a specific player

[Langbart]

While watching a replay, errors popped up:

ERROR: JavaScript error: simulation/components/GuiInterface.js line 258 Script value conversion check failed: v.isNumber() (got type Object) GuiInterface.prototype.GetEntityState@simulation/components/GuiInterface.js:258:36 GuiInterface.prototype.ScriptCall@simulation/components/GuiInterface.js:2141:20 GetEntityState@gui/session/session.js:205:28 EntitySelection.prototype.addList@gui/session/selection.js:297:34 playercommand@gui/session/messages.js:279:15 handleNotifications@gui/session/messages.js:358:43 onSimulationUpdate@gui/session/session.js:667:2 __eventhandler54 (SimulationUpdate)@session SimulationUpdate:1:1

ERROR: Error calling component script function ScriptCall

I used the A25b version.

These errors can be reproduced consistently if you set the view to Mr.michael and Follow them. At about the 8th minute they start to appear.
Or you set the view on airo and follow them, then the errors appear twice once at 1min:15sec and one more time at 7min:20sec. For all other players no errors appear at all

I will attach the replay as a zip file: Mr.michael.zip

[Freagarach]

Does it also happen when the mods are turned off?

[Langbart]

Replying to Freagarach:

Does it also happen when the mods are turned off?

Yes

[Langbart]

Edit: Errors only occur in the perspective of airo and mr.michael. For all other players no errors appear.

[Stan]

252     let cmpTemplateManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_TemplateManager);
253
254     if (!ent)
255         return null;
256
257     // All units must have a template; if not then it's a nonexistent entity id.
258 ->  let template = cmpTemplateManager.GetCurrentTemplateName(ent);
259     if (!template)
260         return null;

Can you see what the value of ent is there ?

[Freagarach]

It is a coordinate, don't ask me why yet.

[Freagarach]

It tries adding the location of a flare to the selection, which, obviously, fails. I'll attach a minimal replay.

[Freagarach]

rP25878 But doesn't really matter.

[Silier]

​https://code.wildfiregames.com/rP25691

[Freagarach]

In 27315:

Use position for positions in unit_commands.js.

Replacing target by position where applicable.
It gave errors when following a player who flared.

Reported by: @Langbart
Differential revision: ​https://code.wildfiregames.com/D4824
Comment by: @Silier
Fixes #6303