Combat Demo (Huge) missing party

[Langbart]

This bug is a bit strange to track down.

to reproduce

• Start your SVN version and play the scenario map Combat Demo (Huge).
  • Everything should be normal.
• Close it and open Combat Demo (Huge) in the Alpha 25 release version.
  • Everything should be normal.
• Close it and go back to the SVN version and open the scenario map Combat Demo (Huge) again.
  • One party is missing

• The only way to restore both parties was to set my SVN version back to [25860] and compile.

Now it's a matter of finding the changeset number that caused the problem. Here's what I would do:

• Start at [25860] and go up one SVN changeset at a time and compile.
• Open the Alpha25 version and play the scenario map Combat Demo (Huge).
• Open the SVN version and play the scenario map Combat Demo (Huge).
  • If both parties are there, I would go up another changeset [25861], [25862], [25863], ...., compile and repeat the process.
  • If not, I would assume this is the changeset number that caused the problem.

For me, the problem seems to be with [25869]. The strange thing is when I go back to [25868] you would assume it would show both parties on the sceneario map Combat Demo (Huge), but it does not. I have to go back to [25860] to see both parties again.

PS: I tested ​Phab:D4305 as there was another error related to [25869] (#6356), but it did not fix the problem.

[Langbart]

Duplicate of #6356.

Jammyjamjamman explained the reason on Phabricator: ​https://code.wildfiregames.com/rP25869#54232

When I applied D4305, It did fix that bug. However, 0AD does some strange caching + retrieval when loading previous scenario maps played. So if you initially played the map with 0ad svn on or after this commit, then apply D4305 and reload this game again, it will load the map with the same (buggy) settings as used on the game before this patch.

Long story short, apply D4305, start the game, select a different map, then select the Combat Demo (Huge) again and the map should load correctly.