PanelEntity aura tooltip missing

[Langbart]

The getAurasTooltip was added with [19536] and could be seen in the bundled release version A22 - Venustas, but somewhere between [19922] (the release number of A22) and [21945] (the release number of A23) the Aura tooltip no longer shows up.

​Line 145 in gui/session/PanelEntity.js

Line
139	PanelEntity.prototype.Tooltips = [
140	getCurrentHealthTooltip,
141	getCurrentCaptureTooltip,
142	getAttackTooltip,
143	getResistanceTooltip,
144	getEntityTooltip,
145	getAurasTooltip
146	];

[19922] contains auras

warn(uneval(panelEntState));

WARNING: ({id:7115, template:"units/sele_hero_antiochus_great", alertRaiser:null, builder:null, canGarrison:true, identity:{rank:"", classes:["Unit", "ConquestCritical", "Organic", "Human", "Hero", "Soldier", "Cavalry", "Melee", "Spear"], visibleClasses:["Hero", "Soldier", "Cavalry", "Melee", "Spear"], selectionGroupName:""}, fogging:null, foundation:null, garrisonHolder:null, gate:null, guard:{entities:[]}, market:null, mirage:null, pack:null, upgrade:null, player:1, position:{x:596.5880432128906, y:43.86955261230469, z:804.4444732666016}, production:null, rallyPoint:null, resourceCarrying:[], rotation:{x:0, y:0, z:0}, trader:null, unitAI:{state:"INDIVIDUAL.IDLE", orders:[], hasWorkOrders:false, canGuard:true, isGuarding:(void 0), canPatrol:true, possibleStances:["violent", "aggressive", "defensive", "passive", "standground"], isIdle:true}, visibility:"visible", hitpoints:1500, maxHitpoints:1500, needsRepair:false, needsHeal:false, canDelete:true, armour:{hack:13, pierce:12, crush:27}, attack:{Melee:{hack:24, pierce:52, crush:0, splash:false, minRange:0, maxRange:6, prepareTime:500, repeatTime:3500, elevationBonus:0, elevationAdaptedRange:(void 0)}, Capture:{value:15, splash:false, minRange:0, maxRange:4, prepareTime:0, repeatTime:1000, elevationBonus:0, elevationAdaptedRange:(void 0)}}, buildingAI:null, heal:null, isBarterMarket:null, loot:{xp:400, food:10, wood:0, stone:0, metal:25}, obstruction:{controlGroup:7115, controlGroup2:0}, turretParent:null, promotion:null, repairRate:null, buildRate:null, resourceDropsite:null, resourceGatherRates:{treasure:1}, resourceSupply:null, resourceTrickle:null, speed:{walk:16.5, run:26}, auras:{'units/heroes/hero_garrison':{name:"Inspired Defense", description:"When garrisoned in a structure or a siege engine, the hero gives it a bonus of +2 capture points recovery rate.", radius:null}, 'units/heroes/sele_hero_antiochus_great':{name:"Ilarch\xE8s", description:"All cavalry gains +2 levels of all armor types.", radius:null}}, extended:true})

warn(uneval(getAurasTooltip(panelEntState)));

WARNING: "[font=\"sans-bold-13\"]Inspired Defense:[/font] [font=\"sans-13\"]When garrisoned in a structure or a siege engine, the hero gives it a bonus of +2 capture points recovery rate.[/font]\n[font=\"sans-bold-13\"]Ilarch\xE8s:[/font] [font=\"sans-13\"]All cavalry gains +2 levels of all armor types.[/font]"

[21945] does not contain auras

warn(uneval(panelEntState));

WARNING: ({id:2172, player:1, template:"ungarrisonable|units/mace_hero_craterus", identity:{rank:"", classes:["Unit", "ConquestCritical", "Organic", "Human", "Hero", "Soldier", "Infantry", "Melee", "Sword"], visibleClasses:["Hero", "Soldier", "Infantry", "Melee", "Sword"], selectionGroupName:"", canDelete:true}, position:{x:304.16773986816406, y:25, z:807.832763671875}, hitpoints:1000, maxHitpoints:1000, needsRepair:false, needsHeal:false, canGarrison:false, unitAI:{state:"INDIVIDUAL.IDLE", orders:[], hasWorkOrders:false, canGuard:true, isGuarding:(void 0), canPatrol:true, selectableStances:["violent", "aggressive", "defensive", "passive", "standground"], isIdle:true}, guard:{entities:[]}, resourceCarrying:[], resourceGatherRates:{treasure:1}, visibility:"visible", attack:{Melee:{Hack:22, Pierce:0, Crush:0, splash:false, minRange:0, maxRange:3.5, prepareTime:375, repeatTime:750, elevationBonus:0, elevationAdaptedRange:(void 0)}, Capture:{value:15, splash:false, minRange:0, maxRange:4, prepareTime:0, repeatTime:1000, elevationBonus:0, elevationAdaptedRange:(void 0)}}, armour:{Hack:12, Pierce:12, Crush:25}, loot:{food:10, wood:0, stone:0, metal:25, xp:400}, speed:{walk:9.44989013671875, run:15.74981689453125}})

warn(uneval(getAurasTooltip(panelEntState)));

WARNING: ""

[Langbart]

updated the version number for A23, I tested the A23b version with [21945] instead of [21821].

[Langbart]

include the changeset set number for casuing the issue

[Langbart]

elexis is not 100% convinced, that I found the right changeset. Woo defines if the auras are part of the panelEntState ?

[Langbart]

It must be [20965]. They removed:

	let cmpAuras = Engine.QueryInterface(ent, IID_Auras);
	if (cmpAuras)
		ret.auras = cmpAuras.GetDescriptions();

When I put it back in, it shows me the aura.

[Freagarach]

In 26896:

Fix aura tooltips on panel entities.

Removed from the GUI interface in r20965 / rP20965, but its uses weren't checked (or ignored).
(​https://code.wildfiregames.com/source/0ad/browse/ps/trunk/binaries/data/mods/public/gui/session/session.js;20965$998)

Reported by @Langbart
Based on a patch by: @Langbart
Differential revision: ​https://code.wildfiregames.com/D4648
Fixes #6387