[macOS] Segmentation fault - framebuffer

[Langbart]

to reproduce

• Start a game from the command line e.g

binaries/system/pyrogenesis -conf=mod.enabledmods:"mod public" -autostart="random/unknown" -autostart-seed=-1 -autostart-civ=1:random -autostart-civ=2:random -autostart-ai=2:petra -autostart-aidiff=2:5

• Segmentation fault. See image below for more clarity.

lldb

(lldb) bt
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x00000001010a3cb0 pyrogenesis`::mozalloc_abort(msg=<unavailable>) at mozalloc_abort.cpp:33:3 [opt]
    frame #1: 0x0000000101b9bc3d pyrogenesis`::abort() at mozalloc_abort.cpp:82:3 [opt]
    frame #2: 0x00000001004f9d86 pyrogenesis`sys_display_error(text=<unavailable>, flags=6) at unix.cpp:268:4 [opt]
    frame #3: 0x00000001004dc503 pyrogenesis`debug_DisplayError(wchar_t const*, unsigned long, void*, wchar_t const*, wchar_t const*, int, char const*, long volatile*) [inlined] CallDisplayError(text=L"Assertion failed: \"framebuffer\"\r\nLocation: DeviceCommandContext.cpp:691 (SetFramebuffer)\r\n\r\nCall stack:\r\n\r\n(error while dumping stack: Function not supported)\r\nerrno = 0 (No error reported here)\r\nOS error = ?\r\n", flags=6) at debug.cpp:374:8 [opt]
    frame #4: 0x00000001004dc4e6 pyrogenesis`debug_DisplayError(description=L"Assertion failed: \"framebuffer\"", flags=6, context=0x00007ffeefbfdfc0, lastFuncToSkip=<no summary available>, pathname=<no summary available>, line=<no summary available>, func=<no value available>, suppress=<no summary available>) at debug.cpp:460 [opt]
    frame #5: 0x00000001004dcd6e pyrogenesis`debug_OnAssertionFailure(expr=<no summary available>, suppress=<no summary available>, file=<no summary available>, line=<no summary available>, func=<no value available>) at debug.cpp:547:9 [opt]
    frame #6: 0x00000001003fb72a pyrogenesis`Renderer::Backend::GL::CDeviceCommandContext::SetFramebuffer(this=<no summary available>, framebuffer=<no summary available>) at DeviceCommandContext.cpp:691:2 [opt]
    frame #7: 0x00000001003be94a pyrogenesis`CSceneRenderer::RenderReflections(this=<unavailable>, deviceCommandContext=<no summary available>, context=<no summary available>, scissor=<no summary available>) at SceneRenderer.cpp:580:24 [opt]
    frame #8: 0x00000001003bfac7 pyrogenesis`CSceneRenderer::RenderSubmissions(this=<unavailable>, deviceCommandContext=<no summary available>, waterScissor=<no summary available>) at SceneRenderer.cpp:810:4 [opt]
    frame #9: 0x00000001003c0d30 pyrogenesis`CSceneRenderer::RenderScene(this=<unavailable>, deviceCommandContext=<no summary available>, scene=<unavailable>) at SceneRenderer.cpp:1161:2 [opt]
    frame #10: 0x00000001003b36ce pyrogenesis`CRenderer::RenderFrameImpl(this=<no summary available>, renderGUI=<no summary available>, renderLogger=<no summary available>) at Renderer.cpp:462:22 [opt]
    frame #11: 0x00000001003b34cd pyrogenesis`CRenderer::RenderFrame(this=<no summary available>, needsPresent=<no summary available>) at Renderer.cpp:417:3 [opt]
    frame #12: 0x0000000100004fb1 pyrogenesis`RunGameOrAtlas(int, char const**) [inlined] Frame() at main.cpp:452:13 [opt]
    frame #13: 0x0000000100004700 pyrogenesis`RunGameOrAtlas(argc=<no summary available>, argv=<no summary available>) at main.cpp:691 [opt]
    frame #14: 0x0000000100002cf6 pyrogenesis`main(argc=<no summary available>, argv=<no summary available>) at main.cpp:743:2 [opt]
    frame #15: 0x00007fff6c9fdcc9 libdyld.dylib`start + 1
    frame #16: 0x00007fff6c9fdcc9 libdyld.dylib`start + 1

bisect

Issue starts with [26613]

[Vladislav Belov]

In 26615:

Fixes rendering reflections even they are disabled, broken in rP15576. Fixes #6454

Reported By: Langbart