Opened 2 years ago

Closed 2 years ago

#6475 closed defect (fixed)

windows: parsing of the log folder in the terms for the feedback is broken

Reported by: marder Owned by: Vladislav Belov
Priority: Must Have Milestone: Alpha 26
Component: UI – Miscellaneous Keywords:
Cc: Patch: ​Phab:D4579

Description (last modified by marder)

image of the falsely parsed path

Reproducible

The feature was added with [21898] and after testing past Alpha versions with VirtualBox. The issue is reproducible for A25 [25860], A24 [24936] and A23b [21935].

Attachments (7)

GetUserReportConfigPath.jpg​ (148.6 KB ) - added by Langbart 2 years ago.
path.jpg​ (75.1 KB ) - added by Langbart 2 years ago.
a25_term.jpg​ (260.0 KB ) - added by Langbart 2 years ago.
a24_term.jpg​ (188.5 KB ) - added by Langbart 2 years ago.
a23b_term.jpg​ (191.4 KB ) - added by Langbart 2 years ago.
a23_noterm.jpg​ (193.4 KB ) - added by Langbart 2 years ago.
screenshot0551.png​ (394.7 KB ) - added by marder 2 years ago.
image of the falsely parsed path

Download all attachments as: .zip

Change History (18)

comment:1 by marder, 2 years ago

Description: modified (diff)

comment:2 by marder, 2 years ago

Description: modified (diff)

comment:3 by Langbart, 2 years ago

Is the problem also reproducible for A25 [25860], A24 [24937] and A23 [21946] ?

The configPath comes from Engine.GetUserReportConfigPath(), that was introduced with [21898] by elexis.

Line 
1var g_TermsUserReport = {
2 "TermsAndConditions": {
3 "title": translateWithContext("UserReporter Terms and Conditions", "Terms"),
4 "instruction": translate("Please read and accept the UserReporter Terms and Conditions."),
5 "file": "gui/userreport/Terms_and_Conditions.txt",
6 "termsURL": Engine.ConfigDB_GetValue("user", "userreport.url_terms"),
7 "sprintf": {
8 "logPath": setStringTags(Engine.GetUserReportLogPath(), { "font": "sans-bold-12" }),
9 "configPath": setStringTags(Engine.GetUserReportConfigPath(), { "font": "sans-bold-12" })
10 },
11 "config": "userreport.terms",

Recent changes.

Last edited 2 years ago by Langbart (previous) (diff)

by Langbart, 2 years ago

Attachment: GetUserReportConfigPath.jpg​ added

comment:4 by Langbart, 2 years ago

Windows uses backslash for the path, on macOS with slash works fine.

by Langbart, 2 years ago

Attachment: path.jpg​ added

comment:5 by marder, 2 years ago

So just the usual os idiosyncrasys

in reply to:  5 comment:6 by Langbart, 2 years ago

Replying to marder:

So just the usual os idiosyncrasys

You could test if A23 was defective from the beginning or if the problem occurred recently? ​https://releases.wildfiregames.com/

comment:7 by Langbart, 2 years ago

Description: modified (diff)

by Langbart, 2 years ago

Attachment: a25_term.jpg​ added

by Langbart, 2 years ago

Attachment: a24_term.jpg​ added

by Langbart, 2 years ago

Attachment: a23b_term.jpg​ added

by Langbart, 2 years ago

Attachment: a23_noterm.jpg​ added

by marder, 2 years ago

Attachment: screenshot0551.png​ added

image of the falsely parsed path

comment:8 by marder, 2 years ago

Description: modified (diff)
Summary: Parsing of the log folder in the terms for the feedback is broken → windows: parsing of the log folder in the terms for the feedback is broken

comment:9 by Langbart, 2 years ago

Patch: → Phab:D4579

comment:10 by Vladislav Belov, 2 years ago

Similar issue was fixed in r20784.

comment:11 by Vladislav Belov, 2 years ago

Owner: set to Vladislav Belov
Resolution: → fixed
Status: new → closed

In 26733:

Escapes paths in user report terms to fix invisible backslashes on Windows. Fixes #6475

Patch By: Langbart

Differential Revision: ​https://code.wildfiregames.com/D4579

Note: See TracTickets for help on using tickets.