Inconsistent fire explosion on destructed buildings

[Langbart]

Play testing on the latest GIT version.

Sometimes large fire clouds arise from destructed buildings. See a couple of examples below.

The particle effect is not consistently reproducible with every time i rewatch the same replay, sometimes these clouds appear, sometimes they are even larger and the particles stay for a long time or disappear quickly, or they don't show up at all. The occurrence and appearance is very inconsistent. The speed you watch might effect the appearance of those particles. I will attach a replay, but you may not even see any fire explosions on every run.

• 2022-04-26_0017.zip

reproducible

I don't recall ever seeing such extreme fire clouds in any of the released versions, there are flying fireballs but they always appear similar and do not vary in size and length of the appearance.

bisect

[26815]

related IRC 0ad-dev

wowgetoffmang ​26/Apr/22

03:28 < wowgetoffmang> I see no blacksmith smoke when the Forge is researching.
03:28 < wowgetoffmang> I see no destruction dust
03:29 < wowgetoffmang> Also, props disappear as a building sinks during destruction
03:32 < Langbart> Currently, I also don't see any smoke on the Forge. I will do some bisecting.
03:34 < wowgetoffmang> Thank you Langbart
03:38 < wowgetoffmang> Hmm, ship selections too?
03:39 < wowgetoffmang> https://trac.wildfiregames.com/changeset/26823
03:39 < wowgetoffmang> ?
04:02 < Langbart> Bisecting by checking the smoke on the HAN forge results in this commit: rP26815

[Langbart]

fix image macro

[Langbart]

adding bisect number and IRC related conversation

[Langbart]

IRC 0ad-dev ​26/Apr/22

05:05 <@Stan> Langbart: Don't think that's on the art team ^
05:05 <@Stan> Also its RB

[Vladislav Belov]

In 26829:

Fixes incorrect vertex buffer offset added in rP26815. Fixes #6519