Changes between Initial Version and Version 1 of Ticket #6527


Ignore:
Timestamp:
May 3, 2022, 6:57:42 AM (2 years ago)
Author:
Langbart
Comment:

Link to the questionable changeset

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #6527 – Description

    initial v1  
    1414
    1515==== bisect
    16 (not yet)
     16[21441] seems to be the candidate that made this change. A concern was raised by `elexis` on this commit.
     17> ''elexis: If my allies were defeated or declared war on me, that shouldn't make me lose the victory timer.''
     18
     19See discussion about this change:
     20https://code.wildfiregames.com/rP21441#31049
    1721
    1822==== reproducible
    19 * Reproducible for the current GIT version and up to A23b.\\
    20 * At `A22 - ​Venustas` the issue is not reproducible, the timer does not reset.
     23* Reproducible for the current GIT version [26850] and up to A23b [21946].\\
     24* At `A22 - ​Venustas` [19922] the issue is not reproducible, the timer does not reset.
     25
     26==== possible solution
     27Maybe set `WonderVictoryPlayerDefeated` to `false` in Line 166 for the [https://code.wildfiregames.com/source/0ad/browse/ps/trunk/binaries/data/mods/public/maps/scripts/WonderVictory.js$166 WonderVictory.js].
     28{{{#!js lineno=165 marks=166
     29        cmpTrigger.RegisterTrigger("OnPlayerWon", "WonderVictoryPlayerWon", { "enabled": true });
     30        cmpTrigger.RegisterTrigger("OnPlayerDefeated", "WonderVictoryPlayerDefeated", { "enabled": false });
     31        cmpTrigger.wonderVictoryMessages = {};
     32}
     33}}}