Changes between Version 1 and Version 2 of Ticket #6553


Ignore:
Timestamp:
Jun 2, 2022, 4:22:58 PM (23 months ago)
Author:
Langbart
Comment:

bisect and chat

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #6553

    • Property Keywords regression added

  • Ticket #6553 – Description

    v1 v2  
    3131                        this.active = new Set();
    3232}}}
     33
     34==== reproducible
     35Issue can be reproduced in A25 [25848], but not in A24 [24937].
     36
     37==== bisect
     38* [25077] would only trigger errors, but still allow interaction with the game setup.
     39[[Image(25077.jpg, 600px, center)]]
     40* [25099] would completely prevent interaction with the game setup
     41[[Image(25099.jpg, 600px, center)]]
     42
     43==== related chat
     44{{{
     45# notes
     46[13:00:09] elexis try wraitii and my gamesetup rewrite
     47[13:00:21] Langbart https://code.wildfiregames.com/D3243 ?
     48[...]
     49[13:02:01] elexis it also introduced a lot of "legacy" keywords, which inherently sounds like adding deprecated code
     50[13:02:56] elexis the idea of my gamesetup code was that the JSON file is loaded, if its not valid JSON it might or might not show an error message but then not do any further errors.
     51[13:02:56] elexis if it is valid JSON it hands over the object to all of the setting parser, and each one takes what is valid or doesn't take anything
     52[13:03:36] elexis but for that process to never break it would require every single setting parser to never break when receiving a valid JSON with bad semantics (according to the revision of the code)
     53[13:04:25] elexis so I guess it can be any commit changing any victory setting parser
     54[13:05:01] elexis I dont know what that legacy code parsing should do, but its usually simpler and more safe to discard an illegal object instead of trying to repair it
     55[13:05:29] elexis so I suspect its better to delete more code than to extend it
     56[...]
     57[13:11:02] elexis SetLegacySetting sounds a lot like supporting to parse old matchsettings
     58[13:12:47] elexis but the fromInitAttributes reads like it always uses this path
     59[13:14:30] elexis perhaps he deems the object structure legacy but didnt add code for a new one and thus just calls the old one legacy?
     60}}}