Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#6559 closed defect (fixed)

Problem: rice as a food subtype

Reported by: Langbart Owned by:
Priority: Should Have Milestone: Alpha 26
Component: Simulation Keywords:
Cc: Patch:

Description (last modified by Langbart)

Gurken Khan pointed out a rice issue

Yeah, no. I hereby petition rice to count as vegetarian! ;)

food.json lists rice as a subtype

Line 
6 "subtypes": {
7 "fish": "Fish",
8 "fruit": "Fruit",
9 "grain": "Grain",
10 "meat": "Meat",
11 "rice": "Rice"
12 },
13 "properties": [
14 "barterable",

The issue was pointed out by Nescio0 with commit ​498061f (16/Jul/20).

Don't introduce rice resource subtype:

  • This is not compatible with the public mod.
  • Making it only available to Han China means their fields are useless when captured by other civs, whereas the reverse is not true.
  • food.grain does not represent only wheat, but also other grains:cereals (e.g. barley, oats, rye, spelt, sorghum, millet, maize, and yes, rice) ...

In a later commit (​de1bd77 (25/Sep/21)) it was reintroduced and later folded into the main game.

related discussion

IRC 0ad-dev 16/May/22

12:09 < marder> do we really need a food.rice resource for the han?
[...]
13:09 <@Stan> @tell marder it was justified since rice fields are smaller iirc

forum threads

slightly related ticket

#6565

Change History (6)

comment:1 by Langbart, 23 months ago

Description: modified (diff)

comment:2 by Langbart, 23 months ago

Priority: Release BlockerShould Have

opinions

[23:21:06] elexis I guess in history all civs could grow rice
[23:21:14] elexis and that its not so difficult is it
[23:21:25] elexis otherwise you could sell it as a feature
[...]
[23:23:32] elexis it should be a design choice to have or not have this effect
[23:23:37] elexis first and foremost

I would definitely advocate giving all units that can collect grain the ability to collect rice as well, because in the long run a user will come and create a ticket that a rice field cannot be used if it is in the sphere of influence of a player from a non-Han civilisation.

Lowering the priority

[23:25:58] Langbart Release blocker is too harsh? 
[...]
[23:27:14] elexis dunno, was just wondering, RB is definitely harsh

comment:3 by Freagarach, 23 months ago

Rice is counted as a vegetarian type in [26931].

comment:4 by Langbart, 23 months ago

Description: modified (diff)

link to related ticket #6565

comment:5 by wowgetoffyourcellphone, 23 months ago

Resolution: fixed
Status: newclosed

Fixed in:

https://trac.wildfiregames.com/changeset/26937

comment:6 by Langbart, 23 months ago

[26937] [Alpha 26] Remove the food.rice distinction and subsequent animation variants. Fixes some odd behavior. Fixes #6559 Fixes #6565 Refs #6566

Note: See TracTickets for help on using tickets.