id	summary	reporter	owner	description	type	status	priority	milestone	component	resolution	keywords	cc	phab_field
6559	Problem: rice as a food subtype	Langbart		"`Gurken Khan` pointed out a rice issue
> Yeah, no. I hereby petition rice to count as vegetarian! ;)
* [https://wildfiregames.com/forum/topic/82754-alpha-26-pre-releaserelease-candidate-build-testing/page/2/#comment-502523 Alpha 26 Pre-release/Release Candidate Build Testing] (9/Jun/22)

[https://code.wildfiregames.com/source/0ad/browse/ps/trunk/binaries/data/mods/public/simulation/data/resources/food.json$11 food.json] lists rice as a subtype
{{{#!json lineno=6 marks=11
	  ""subtypes"": {
    ""fish"": ""Fish"",
    ""fruit"": ""Fruit"",
    ""grain"": ""Grain"",
    ""meat"": ""Meat"",
    ""rice"": ""Rice""
  },
  ""properties"": [
    ""barterable"",
}}}

The issue was pointed out by `Nescio0` with commit ​[https://github.com/0ADMods/han_china/commit/498061f345a6feb4eea04e9aef183ff7301b3ca7 498061f] (16/Jul/20). 
> Don't introduce rice resource subtype:
> * This is **not compatible with the public mod**.
> * Making it **only available to Han China means their fields are useless when captured by other civs**, whereas the reverse is not true.
> * food.grain does not represent only wheat, but also other grains:cereals (e.g. barley, oats, rye, spelt, sorghum, millet, maize, **and yes, rice**) ...

In a later commit (​[https://github.com/0ADMods/han_china/commit/de1bd77a9593092e9af2de34758226634253fedf de1bd77] (25/Sep/21)) it was reintroduced and later folded into the main game.

==== related discussion
IRC 0ad-dev [https://irclogs.wildfiregames.com/%230ad-dev/2022-05-16-QuakeNet-%230ad-dev.log 16/May/22]

{{{
12:09 < marder> do we really need a food.rice resource for the han?
[...]
13:09 <@Stan> @tell marder it was justified since rice fields are smaller iirc
}}}

forum threads
* [https://wildfiregames.com/forum/topic/38729-addition-of-han-chinese-to-0ad/ Addition of Han Chinese to 0AD] (20/Apr/21)
* [https://wildfiregames.com/forum/topic/71582-fixing-chinese-han/ Fixing Chinese Han] (20/Feb/22)"	defect	new	Release Blocker	Alpha 26	Simulation