Han gather_grain animation is not chosen correctly for Spearman and Pikeman

[Langbart]

I could not find the steps to reproduce the problem conclusively, but it happened to me at least twice and only with the Han. See the attached replay (animation_broke_rice_gather.txt) and the GIF below for more clarity. The unit still farms, but the gather_grain animation does not work properly.

possibly related

Similar sounding problem reported by borg via the forum

• ​Han women cant get food from farms after "gift from the gods" (11/Jun/22)

EDIT 12/Jun/22 with [26937]

The issue is still noticeable, see attached replay (farmMe_rP26937.txt ~3min mark) and GIF below for more clarity. The unit simply stops the animation, still gathering though.

EDIT 13/Jun/22

Reproduce: Add a small distance between the rice field and the drop point, so that the unit has to walk. The problem can only be observed for Han citizen-soldiers.

Seems to do with approach_rice.xml and the line <variant file="biped/approach_rice.xml"/> in the binaries/data/mods/public/art/actors/units/han/ files. Ref: [26937]

Update

to reproduce

• Open Atlas and place a CC and a Han rice field next to each other without leaving a gap between them.
• Place a han/infantry_spearman_b.xml and a han/infantry_halberdman_b.xml and start the simulation. (Only these two unit types - Spearman and Pikeman - are affected by the Han.)
• Order them to gather
• Wait until they reach the CC, the animation for gathering is not chosen.

issue

wiki/Actors#Randomnessandselections

If two variants have equal frequency values, they have equal chance of being selected.

I think in Atlas the top line is always chosen, moving the line for gather_grain above carry_food would also work, at least in Atlas.

binaries/data/mods/public/art/actors/units/han/infantry_spearman_b.xml

@@ -33 +33 @@
   </group>
   <group>
     <variant file="biped/base_spearman_shield_relax.xml"/>
+    <variant file="biped/gather_grain.xml"/>
     <variant file="biped/carry_food.xml">
       <props>
         <prop actor="props/units/helmets/han_ricehat.xml" attachpoint="helmet"/>
@@ -43 +44 @@
     <variant file="biped/formations/anti_cavalry_back.xml"/>
     <variant file="biped/attack_slaughter.xml"/>
     <variant file="biped/gather_tree.xml"/>
-    <variant file="biped/gather_grain.xml"/>
     <variant file="biped/gather_fruit.xml"/>
     <variant file="biped/gather_meat.xml"/>
     <variant file="biped/gather_rock.xml"/>

possible solution

binaries/data/mods/public/art/actors/units/han/infantry_spearman_b.xml

@@ -38 +38 @@
         <prop actor="props/units/helmets/han_ricehat.xml" attachpoint="helmet"/>
       </props>
     </variant>
-    <variant file="biped/attack_capture.xml"/>
-    <variant file="biped/formations/anti_cavalry_front.xml"/>
-    <variant file="biped/formations/anti_cavalry_back.xml"/>
-    <variant file="biped/attack_slaughter.xml"/>
-    <variant file="biped/gather_tree.xml"/>
-    <variant file="biped/gather_grain.xml"/>
-    <variant file="biped/gather_fruit.xml"/>
-    <variant file="biped/gather_meat.xml"/>
-    <variant file="biped/gather_rock.xml"/>
-    <variant file="biped/gather_ore.xml"/>
-    <variant file="biped/gather_ruins.xml"/>
-    <variant file="biped/gather_praise.xml"/>
-    <variant file="biped/build.xml"/>
-    <variant file="biped/build_farm.xml"/>
-    <variant file="biped/death_infantry.xml"/>
     <variant file="biped/carry_meat.xml"/>
     <variant file="biped/carry_wood.xml"/>
     <variant file="biped/carry_stone.xml"/>
@@ -68 +53 @@
     <variant file="biped/approach_praise.xml"/>
   </group>
   <group>
-    <variant name="Idle"/>
+    <variant frequency="1" name="Idle"/>
+    <variant file="biped/attack_capture.xml"/>
+    <variant file="biped/attack_slaughter.xml"/>
+    <variant file="biped/gather_tree.xml"/>
+    <variant file="biped/gather_grain.xml"/>
+    <variant file="biped/gather_fruit.xml"/>
+    <variant file="biped/gather_meat.xml"/>
+    <variant file="biped/gather_rock.xml"/>
+    <variant file="biped/gather_ore.xml"/>
+    <variant file="biped/gather_ruins.xml"/>
+    <variant file="biped/gather_praise.xml"/>
+    <variant file="biped/build.xml"/>
+    <variant file="biped/build_farm.xml"/>
+    <variant file="biped/death_infantry.xml"/>
   </group>
   <material>player_trans.xml</material>
 </actor>

additional nitpick

Other actors, such as romans/infantry_spearman_b.xml, should receive a similar treatment.

[wowgetoffyourcellphone]

Ref: https://trac.wildfiregames.com/changeset/26937

[Langbart]

[26937] [Alpha 26] Remove the food.rice distinction and subsequent animation variants. Fixes some odd behavior. Fixes #6559 Fixes #6565 Refs #6566

[Langbart]

will be checked tomorrow with the new Git update and is expected to be closed as well.

[Langbart]

final update

[Stan]

In 26961:

Fix missing animations for grain gathering for han units. This workarounds a bug in UnitAI and improves consistency with other actors. Show the rice hat for approaching, returning and gathering grain.
Refs #6566

[Stan]

In 26962:

Fix missing animations for grain gathering for pikemen. is workarounds a bug in UnitAI and improves consistency with other actors.

Refs #6566

[Stan]

In 26963:

Fix missing animations for grain gathering for swordsmen. This workarounds a bug in UnitAI and improves consistency with other actors.
Refs #6566

[Stan]

In 26964:

Fix missing animations for grain gathering for spearmen. This workarounds a bug in UnitAI and improves consistency with other actors.
Refs #6566

[Stan]

UnitAI.prototype.SetAnimationVariant@simulation/components/UnitAI.js:4584:7 
UnitAI.prototype.SetDefaultAnimationVariant@simulation/components/UnitAI.js:4607:9 
enter@simulation/components/UnitAI.js:2673:11 
FSM.prototype.SwitchToNextState@globalscripts/FSM.js:366:14 
FSM.prototype.ProcessMessage@globalscripts/FSM.js:274:8 
UnitAI.prototype.ProcessMessage@simulation/components/UnitAI.js:4347:15 
ResourceGatherer.prototype.StopGathering@simulation/components/ResourceGatherer.js:243:14 
ResourceGatherer.prototype.PerformGather@simulation/components/ResourceGatherer.js:286:8 
Timer.prototype.OnUpdate@simulation/components/Timer.js:139:44

WARNING: carry_food

UnitAI.prototype.SetAnimationVariant@simulation/components/UnitAI.js:4584:7 
enter@simulation/components/UnitAI.js:2461:11 FSM.prototype.SwitchToNextState@globalscripts/FSM.js:366:14 
FSM.prototype.ProcessMessage@globalscripts/FSM.js:274:8 
UnitAI.prototype.OnMotionUpdate@simulation/components/UnitAI.js:4268:15

WARNING: approach_grain

WARNING: GATHERING
WARNING: RETURNINGRESOURCE
WARNING: DROPPINGRESOURCES
WARNING: GATHER.APPROACHING
WARNING: GATHERING

It seems that when the field is too close, something is not reset properly.

[Freagarach]

​https://code.wildfiregames.com/D4937 should fix the UnitAI issue. I guess it would be nice if we wouldn't need to rely on stuff hidden away in UnitAI. '

[Freagarach]

In 27550:

Fix missing animation variant reset after committing resources in UnitAI.

Causing units to not show the gathering animation when close to a dropsite.
We might want to move this stuff to their respective components.

Differential revision: ​https://code.wildfiregames.com/D4937
Comments by: @Stan
Fixes #6566