| 18 | | Seems to do with `approach_rice.xml` and the line `<variant file="biped/approach_rice.xml"/>` in the `binaries/data/mods/public/art/actors/units/han/` files. |
| 19 | | Ref: [26937] |
| | 18 | ~~Seems to do with `approach_rice.xml` and the line `<variant file="biped/approach_rice.xml"/>` in the `binaries/data/mods/public/art/actors/units/han/` files. |
| | 19 | Ref: [26937]~~ |
| | 20 | |
| | 21 | = Update |
| | 22 | ==== to reproduce |
| | 23 | * Open `Atlas` and place a CC and a `Han` rice field next to each other without leaving a gap between them. |
| | 24 | * Place a `han/infantry_spearman_b.xml` and a `han/infantry_halberdman_b.xml` and start the simulation. (Only these two unit types - Spearman and Pikeman - are affected by the `Han`.) |
| | 25 | * Order them to gather |
| | 26 | * Wait until they reach the CC, the animation for gathering is not chosen. |
| | 27 | |
| | 28 | ==== issue |
| | 29 | [[Actors#Randomnessandselections|wiki/Actors#Randomnessandselections]] |
| | 30 | > If two variants have equal frequency values, they have equal chance of being selected. |
| | 31 | I think in Atlas the top line is always chosen, moving the line for `gather_grain` above `carry_food` would also work, at least in Atlas. |
| | 32 | {{{#!diff |
| | 33 | --- a/binaries/data/mods/public/art/actors/units/han/infantry_spearman_b.xml |
| | 34 | +++ b/binaries/data/mods/public/art/actors/units/han/infantry_spearman_b.xml |
| | 35 | @@ -33,6 +33,7 @@ |
| | 36 | </group> |
| | 37 | <group> |
| | 38 | <variant file="biped/base_spearman_shield_relax.xml"/> |
| | 39 | + <variant file="biped/gather_grain.xml"/> |
| | 40 | <variant file="biped/carry_food.xml"> |
| | 41 | <props> |
| | 42 | <prop actor="props/units/helmets/han_ricehat.xml" attachpoint="helmet"/> |
| | 43 | @@ -43,7 +44,6 @@ |
| | 44 | <variant file="biped/formations/anti_cavalry_back.xml"/> |
| | 45 | <variant file="biped/attack_slaughter.xml"/> |
| | 46 | <variant file="biped/gather_tree.xml"/> |
| | 47 | - <variant file="biped/gather_grain.xml"/> |
| | 48 | <variant file="biped/gather_fruit.xml"/> |
| | 49 | <variant file="biped/gather_meat.xml"/> |
| | 50 | <variant file="biped/gather_rock.xml"/> |
| | 51 | }}} |
| | 52 | |
| | 53 | ==== possible solution |
| | 54 | {{{#!diff |
| | 55 | --- a/binaries/data/mods/public/art/actors/units/han/infantry_spearman_b.xml |
| | 56 | +++ b/binaries/data/mods/public/art/actors/units/han/infantry_spearman_b.xml |
| | 57 | @@ -38,21 +38,6 @@ |
| | 58 | <prop actor="props/units/helmets/han_ricehat.xml" attachpoint="helmet"/> |
| | 59 | </props> |
| | 60 | </variant> |
| | 61 | - <variant file="biped/attack_capture.xml"/> |
| | 62 | - <variant file="biped/formations/anti_cavalry_front.xml"/> |
| | 63 | - <variant file="biped/formations/anti_cavalry_back.xml"/> |
| | 64 | - <variant file="biped/attack_slaughter.xml"/> |
| | 65 | - <variant file="biped/gather_tree.xml"/> |
| | 66 | - <variant file="biped/gather_grain.xml"/> |
| | 67 | - <variant file="biped/gather_fruit.xml"/> |
| | 68 | - <variant file="biped/gather_meat.xml"/> |
| | 69 | - <variant file="biped/gather_rock.xml"/> |
| | 70 | - <variant file="biped/gather_ore.xml"/> |
| | 71 | - <variant file="biped/gather_ruins.xml"/> |
| | 72 | - <variant file="biped/gather_praise.xml"/> |
| | 73 | - <variant file="biped/build.xml"/> |
| | 74 | - <variant file="biped/build_farm.xml"/> |
| | 75 | - <variant file="biped/death_infantry.xml"/> |
| | 76 | <variant file="biped/carry_meat.xml"/> |
| | 77 | <variant file="biped/carry_wood.xml"/> |
| | 78 | <variant file="biped/carry_stone.xml"/> |
| | 79 | @@ -68,7 +53,20 @@ |
| | 80 | <variant file="biped/approach_praise.xml"/> |
| | 81 | </group> |
| | 82 | <group> |
| | 83 | - <variant name="Idle"/> |
| | 84 | + <variant frequency="1" name="Idle"/> |
| | 85 | + <variant file="biped/attack_capture.xml"/> |
| | 86 | + <variant file="biped/attack_slaughter.xml"/> |
| | 87 | + <variant file="biped/gather_tree.xml"/> |
| | 88 | + <variant file="biped/gather_grain.xml"/> |
| | 89 | + <variant file="biped/gather_fruit.xml"/> |
| | 90 | + <variant file="biped/gather_meat.xml"/> |
| | 91 | + <variant file="biped/gather_rock.xml"/> |
| | 92 | + <variant file="biped/gather_ore.xml"/> |
| | 93 | + <variant file="biped/gather_ruins.xml"/> |
| | 94 | + <variant file="biped/gather_praise.xml"/> |
| | 95 | + <variant file="biped/build.xml"/> |
| | 96 | + <variant file="biped/build_farm.xml"/> |
| | 97 | + <variant file="biped/death_infantry.xml"/> |
| | 98 | </group> |
| | 99 | <material>player_trans.xml</material> |
| | 100 | </actor> |
| | 101 | }}} |
| | 102 | |
| | 103 | ==== additional nitpick |
| | 104 | Other actors, such as `romans/infantry_spearman_b.xml`, should receive a similar treatment. |
