Flickering tooltip for user report button

[Langbart]

The issue was reported by max_torch

• ​Mouse hover tooltip of the "Enable Feedback" button flickers rapidly (23/Jun/22)

to reproduce

• Open 0 A.D.
• Move the cursor above the Enable Feedback button in the bottom right corner
• See GIF below for more clarity

possible solution

• Remove the tooltip or make use of the pgToolTip object.

  binaries/data/mods/public/gui/pregame/userreport/userreport.xml

  @@ -7 +7 @@
   
       <object type="text" name="userReportText" style="userReportText" size="2 2 100%-2 100%-40"/>
   
  -    <object type="button" name="userReportEnableButton" style="StoneButton" size="8 100%-36 151 100%-8"/>
  +    <object type="button" name="userReportEnableButton" style="StoneButton" tooltip_style="pgToolTip" size="8 100%-36 151 100%-8"/>
       <object type="button" name="userReportTermsButton" style="StoneButton" size="100%-151 100%-36 100%-8 100%-8"/>
   
   </object>

reproducible

The poor positioning of the tooltip has been there since A23b, but the severe flickering started with A25b. There was NO flickering in A24b. Why does it flicker?

related discussion

IRC 0ad-dev ​15/May/22

20:31 <@Stan> Someone reported that the userreporter flickers on macos
[...]
20:32 <@Stan> I think it triggers some z fighting with macos widgets

[Stan]

Hey Langbart,

Care to explain how it fixes it to use that style? I don't see what helps in ​gui/common/setup.xml:L24

Otherwise if it works I will commit it.

[Langbart]

The tooltip is moved to the upper right corner to match all other buttons in the main menu.