Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#6588 closed defect (invalid)

ungarrisonable filter does nothing

Reported by: Andy Alt Owned by:
Priority: Should Have Milestone:
Component: Simulation Keywords:
Cc: Patch:

Description

The filter disableGarrisonHolder.xml was renamed to ungarrisonable.xml (2 or 3 releases ago?)

I tried using it for a wonder, but it doesn't do anything.

I think it's because the only template that seems to be using the 'Garrisonable' field is templates/template_unit.xml

That's the field specified in the 'ungarrisonable.xml' filter:

<Entity merge="">
  <Garrisonable disable=""/>
</Entity>

But the other templates are using the 'GarrisonHolder' field; for example, template_structure_wonder.xml:

  <GarrisonHolder>
    <Max>50</Max>
    <EjectHealth>0.1</EjectHealth>
    <EjectClassesOnDestroy datatype="tokens">Unit</EjectClassesOnDestroy>
    <List datatype="tokens">Support Soldier</List>
    <BuffHeal>5</BuffHeal>
    <LoadingRange>2</LoadingRange>
  </GarrisonHolder>

Change History (3)

comment:1 by Freagarach, 21 months ago

I'm not sure that disableGarrisonHolder was actually renamed? The ungarrisonable seems like it is used for disabling hero garrison in regicide matches?

So I think this can be closed as invalid. Feel free to argue otherwise.

comment:2 by Andy Alt, 21 months ago

Resolution: invalid
Status: newclosed

I think you're right. I checked git tags back to a23 and there's no disableGarrisonHolder.xml filter. It just happens to be in the community maps mod and apparently was never included in the 0ad official distribution.

comment:3 by Stan, 21 months ago

Milestone: Alpha 27
Note: See TracTickets for help on using tickets.