#6603 closed defect (fixed)

[macOS] mod.json issue

Reported by: Langbart Owned by: Stan
Priority: Release Blocker Milestone: Alpha 26
Component: Core engine Keywords:
Cc: Patch: Phab:D4765

Description

to reproduce

  1. place a mod into your 0ad/mods folder (see wiki/GameDataPaths)
    • for example git clone https://github.com/nanihadesuka/autociv.git
  2. start pyrogenesis
  3. warnings come up and files are being written to the directory you started the command from containing infos from mod.json
  4. see warnings, images and log output below for more clarity

Warnings

0 A.D. (0.0.26) Main log (warnings and errors only)
WARNING: Could not write external mod.json for zipped mod 'public'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'Macedonia_0ad'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod '0ad-space'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'community-maps-2-git'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'ffm_4k'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod '0ad_GoodCursor'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'boonGUI'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'delenda_est'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'mare_nostrum'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'LocalRatings'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'fgod.exp.280320201820'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'autociv'. The mod should be reinstalled.

WARNING: Could not write external mod.json for zipped mod 'rl-scenarios'. The mod should be reinstalled.

Engine exited successfully on 2022-08-16 at 12:38:42 with 469 message(s), 0 error(s) and 13 warning(s).

Images

Log Output

These warnings showed up when compiling the game after upgrading from [27054] to [27056].

==== Building scriptinterface (release) ====
==== Building engine (release) ====
Mod.cpp
ModInstaller.cpp
ModIo.cpp
../../../source/ps/ModInstaller.cpp:121:28: warning: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
        const char* modJsonPath = OsString(modDir / L"mod.json").c_str();
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../source/ps/Mod.cpp:62:28: warning: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
        const char* modJsonPath = OsString(modsPath / mod / L"mod.json").c_str();
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
1 warning generated.
Linking engine
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols
==== Building graphics (release) ====

bisect

either it was [27055] or [27056]

note

It was reproducible even after deleting the cache folder and doing a clean install.

Attachments (2)

desk.jpg (171.8 KB ) - added by Langbart 20 months ago.
pyro.jpg (267.2 KB ) - added by Langbart 20 months ago.

Download all attachments as: .zip

Change History (6)

by Langbart, 20 months ago

Attachment: desk.jpg added

by Langbart, 20 months ago

Attachment: pyro.jpg added

comment:1 by Stan, 20 months ago

Owner: set to Stan

comment:2 by Stan, 20 months ago

Patch: Phab:D4765

comment:3 by Stan, 20 months ago

Sorry about that Langbart, thanks for testing! Should be fixed by the patch above.

comment:4 by Stan, 20 months ago

Resolution: fixed
Status: newclosed

In 27058:

Fix Phab:rP27056
Reported by: @Langbart
Accepted by: @Vladislavbelov
Tested by: @Langbart
Fixes: #6603
Differential Revision: https://code.wildfiregames.com/D4765

Note: See TracTickets for help on using tickets.