Fails to open single player matches after enabling RegicideGarrison for a random map

[elconde]

Enabling RegicideGarrison for a random triggers the following error after re-entering single player match:

ERROR: JavaScript error: gamesettings/GameSettings.js line 97
Infinite loop initializing attributes detected, components: ["biome", "campaignData", "ceasefire", "cheats", "circularMap", "daytime", "disableSpies", "disableTreasures", "gameSpeed", "landscape", "lastManStanding", "lockedTeams", "map", "mapExploration", "mapName", "mapPreview", "mapSize", "matchID", "nomad", "playerAI", "playerCiv", "playerColor", "playerCount", "playerName", "playerTeam", "population", "rating", "regicideGarrison", "relic", "seaLevelRise", "seeds", "startingCamera", "startingResources", "teamPlacement", "triggerDifficulty", "triggerScripts", "victoryConditions", "wonder"]
  fromInitAttributes@gamesettings/GameSettings.js:97:9
  parseSettings@gui/gamesetup/Controllers/GameSettingsController.js:191:18
  onLoad@gui/gamesetup/Controllers/GameSettingsController.js:89:10
  SetupWindow@gui/gamesetup/SetupWindow.js:61:11
  init@gui/gamesetup/gamesetup.js:47:18
  onPress@gui/pregame/MainMenuItems.js:99:13
  performButtonAction@gui/pregame/MainMenuItemHandler.js:77:9
  pressButton@gui/pregame/MainMenuItemHandler.js:63:10
ERROR: GUI page 'page_gamesetup.xml': Failed to call init() function

Refs: ​https://wildfiregames.com/forum/topic/95151-i-dont-know-what-to-do-can-someone-help-me-and-explain/

[Norse_Harold]

Steps to reproduce

1. Start 0 A.D.
2. Click Settings, Options, Game Setup.
3. Ensure that "Persist match settings" is enabled.
4. Click Save, Close.
5. Open 0 A.D., click Single Player, Matches.
6. Click Map, change Map Type to "Random", click Browse Maps, then choose "Mainland". It's probably on page 19 of the map list. After clicking on "Mainland", click Select.
7. Click Game Type, then enable "Regicide" and "Hero Garrison".
8. Click Start Game!
9. Click Menu, Exit, Quit.
10. Click Exit, Yes.
11. Open 0 A.D. again.
12. Click Single Player, Matches.

The symptoms in the screenshot should then occur. In this case, you can terminate 0 A.D. by pressing Alt+F4.

Workaround

1. Ensure that 0 A.D. is shut down.
2. Delete matchsettings.json and matchsettings.mp.json from the ​Game Data User Config directory.
3. Start 0 A.D. again.
4. Do NOT enable both of "Hero Garrison" and "Persist match settings" at the same time.

0 A.D. should work correctly again.

Also see ​Video instructions on how to disable "Persist match settings"

[Vladislav Belov]

Another report: #6645

[Stan]

fixed in r27135

[Norse_Harold]

Another report: #6828. It's the multiplayer gamesetup variant.