%(resource)s are not translated in AI private messages

[Gurken Khan]

When AIs make demands in private messages the resources are not translated but use the English terms like "food".

​PetraAI bot doesn't recognize defeat of competitor, it's trading with (11/Oct/22)

possible solution ?

binaries/data/mods/public/simulation/ai/petra/chatHelper.js

@@ -225 +225 @@
         "message": "/msg " + gameState.sharedScript.playersData[player].name + " " +
             pickRandom(this.answerDiplomacyRequestMessages[requestType][response]),
         "translateMessage": true,
-        "translateParameters": requiredTribute ? ["_amount_", "_resource_", "_player_"] : ["_player_"],
+        "translateParameters": { "_resource_": "withinSentence" } ,
         "parameters": requiredTribute ?
-            { "_amount_": requiredTribute.wanted, "_resource_": requiredTribute.type, "_player_": player } :
+            { "_amount_": requiredTribute.wanted, "_resource_": Resources.GetNames()[requiredTribute.type], "_player_": player } :
             { "_player_": player }
     });
 };

• the Resources.GetNames()[requiredTribute.type] transforms wood into Wood
• the { "_resource_": "withinSentence" } for finding the correctly translated word with the translateObjectKeys function in ChatMessageFormatPlayer.js.

​l10n/nl.public-gui-other.po

Line
7285	#. Translation: Word as used at the beginning of a sentence or as a single-
7286	#. word sentence.
7287	#: simulation/data/resources/wood.jsonname
7288	msgctxt "firstWord"
7289	msgid "Wood"
7290	msgstr "Hout"
7291
7292	#. Translation: Word as used in the middle of a sentence (which may require
7293	#. using lowercase
7294	#. for your language).
7295	#: simulation/data/resources/wood.jsonname
7296	msgctxt "withinSentence"
7297	msgid "Wood"
7298	msgstr "Hout"
7299
7300	#. Translation: Word as used at the beginning of a sentence or as a single-
7301	#. word sentence.
7302	#: simulation/data/resources/wood.jsonsubtypes.tree
7303	msgctxt "firstWord"
7304	msgid "Tree"
7305	msgstr "Boom"

note

the missing space in the dutch text, which can be seen in the image above, is a problem of the translator and is not caused by this patch

​l10n/nl.public-simulation-other.po

Line
245	#: simulation/ai/petra/chatHelper.js:81
246	#, javascript-format
247	msgid ""
248	"%(_player_)s, you must send me a tribute of %(_amount_)s %(_resource_)s "
249	"before I accept an alliance with you."
250	msgstr "%(_player_)s, u moet eerst %(_amount_)s%(_resource_)s als geschenk sturen voordat ik een bondgenootschap met u accepteer."

[Langbart]

possible solution

[Freagarach]

In 27467:

Translate resources in PetraAI's tribute demands.

Reported by Gurken Khan at ​https://wildfiregames.com/forum/topic/96576-petraai-bot-doesnt-recognize-defeat-of-competitor-its-trading-with.

Based on a patch by: @Langbart
Differential revision: ​https://code.wildfiregames.com/D4897
Accepted by: @Langbart
Fixes #6648