Opened 14 months ago

Closed 6 days ago

#6755 closed defect (fixed)

Incorrect description for modifying the BatchTimeModifier

Reported by: Langbart Owned by:
Priority: Should Have Milestone: Alpha 27
Component: UI & Simulation Keywords:
Cc: Patch:

Description

to reproduce

  • start a game with Athens
  • build a barracks and look at the time it takes to train Hoplites in different batches
  • research Conscription source:ps/trunk/binaries/data/mods/public/art/textures/ui/session/portraits/technologies/fist_spear_fire.png@27570 and look at the time it takes to train Hoplites again
    Line 
    1{
    2 "genericName": "Conscription",
    3 "description": "Significantly increase training speed of infantry by training them in large batches or companies.",
    4 "cost": {
    5 "food": 500
    6 },
    7 "requirements": {
    8 "all": [
    9 { "tech": "phase_city" },
    10 { "notciv": "pers" }
    11 ]
    12 },
    13 "requirementsTooltip": "Unlocked in City Phase.",
    14 "icon": "ist_spear_fire.pngf",
    15 "researchTime": 40,
    16 "tooltip": "Barracks −10% batch training time.",
    17 "modifications": [
    18 { "value": "Trainer/BatchTimeModifier", "add": -0.1 }
    19 ],
    20 "affects": ["Barracks"],
    21 "soundComplete": "interface/alarm/alarm_upgradearmory.xml"
    22}
Batch size Normal Time
(in seconds) 		Conscription Time
(in seconds) 		% Change
5 37 31 -16.22%
10 64 51 -20.3%
15 88 67 -23.86%
20 110 82 -25.45%

A reduction of 0.1 will not result in a 10% reduction in batch time. It will always depend on the batch size, thus any description claiming a constant percentage reduction is incorrect.

Batch Training Time = costBuildTime * batchSizebatchTimeModifier

Changing the Cost Build Time
Batch Training Time change = newCostBuildTime/oldCostBuildTime -1

Changing the Batch Time Modifier
Batch Training Time change = batchSizenewBatchTimeModifier - oldBatchTimeModifier -1

  • BatchTimeFactor was added with [12877]

affected files:

possible solution (1)

  • Adapt description to vaguely describe that there is a reduction
    • it must be short and precise, no long, overly complex, compound sentences

possible solution (2)

  • modify Cost/BuildTime instead of Trainer/BatchTimeModifier 
        "modifications": [
        { "value": "Cost/BuildTime", "multiply": 0.9 },

Change History (3)

comment:1 by marder, 13 months ago

In 27584:

[Gameplay] - Adjust batch modifier from upgraded Han CC

Reported on the Forums: ​https://wildfiregames.com/forum/topic/106426-incredibly-fast-training-times/

Solution: Use half the current value (for now)

Refs: #6755 because of the description

accepted by: no one, but there seemed to be a general agreement that a reduction would be ok.

Differential Revision: ​https://code.wildfiregames.com/D4961

comment:2 by phosit, 11 months ago

costBuildTime * batchSizeModifierBuilding + ModifierTech0 + ModifierTech1

can also be expressed like this:

costBuiltTime * batchSizeModifierBuilding * batchSizeModifierTech0 * batchSizeModifierTech1

Then the description of the tech would only had to talk about it's factor: Changes the training time by a factor of batchSize^-0,1. or Devides the training time by batchSize^0,1.

A tech which does multiply (only the Han CC) can't be represented in this notion.

Last edited 11 months ago by phosit (previous) (diff)

comment:3 by phosit, 6 days ago

Resolution: → fixed
Status: new → closed

Fixed by [28065]

Note: See TracTickets for help on using tickets.