Opened 8 years ago

Closed 18 months ago

Last modified 18 months ago

#763 closed defect (fixed)

[PATCH] Player and resource colors conflict on minimap

Reported by: Ben Brian Owned by: Imarok
Priority: Nice to Have Milestone: Alpha 22
Component: UI & Simulation Keywords: patch
Cc: DalerankN8@… Patch:

Description (last modified by elexis)

On the minimap, metal mines are shown as yellow which is very similar to player 4's color. Animals are shown as orange which is similar to player 7.

One or the other should be tweaked slightly so the players and resources can be more clearly distinguished.

Attachments (23)

Recolouring.jpg (251.9 KB) - added by Ross Bearman 7 years ago.
Proposed recolouring.
minimap.jpg (68.1 KB) - added by Erik Johansson 6 years ago.
Current (24th June 2012) state of the minimap
recoloring_minimap_color_issue_763.patch (2.0 KB) - added by Sergey Kushnirenko 3 years ago.
MillenniumAD colors.png (242.9 KB) - added by Niek 3 years ago.
Per elexis' request: a few screenshots. Note that the Millennium A.D. color scheme aims to look more natural (and less neon-like)
Millennium A.D. Colors Volcanic Lands.png (62.9 KB) - added by Niek 3 years ago.
And on Volcanic Lands
1000ad15022016.png (75.2 KB) - added by Niek 3 years ago.
New fauna and metal mine colors in 1,000 A.D.
minimap_color.zip (3.8 KB) - added by Niek 3 years ago.
Color scheme (as of 31-03) in Millennium A.D. moved to a separate mod for testing
minimap_color (v2).zip (3.8 KB) - added by Niek 3 years ago.
Improved metal mine color (and swapped with the bushes)
Minimap current state.png (223.1 KB) - added by Niek 3 years ago.
This is the current state of the mod
minimap_color (v3).zip (3.9 KB) - added by Niek 3 years ago.
And the updated files
763.diff (4.1 KB) - added by stanislas69 3 years ago.
Patch of the above zip
minicolors.patch (3.6 KB) - added by Grugnas 23 months ago.
Resources recolor and Yellow Player recolor (it is kinda golden now, darker than the original in order to make a wider gap between metal and the player units, expecially while blinking)
New minimap.png (127.7 KB) - added by Niek 19 months ago.
minimap_color.2.zip (3.9 KB) - added by Niek 19 months ago.
New version following last week's discussion
minimap_color.patch (5.2 KB) - added by Niek 19 months ago.
An as a patch too
minimap_color.2.patch (4.3 KB) - added by Niek 19 months ago.
Shouldn't revert older commits
minimap_colors.patch (3.5 KB) - added by Niek 19 months ago.
Evil spaces
diplo_screen.jpg (96.1 KB) - added by elexis 18 months ago.
gamesetup.jpg (113.2 KB) - added by elexis 18 months ago.
mainland.jpg (27.1 KB) - added by elexis 18 months ago.
volcano.jpg (25.9 KB) - added by elexis 18 months ago.
screenshot0072.png (54.3 KB) - added by Imarok 18 months ago.
yellow metal
763_minimap_colors.patch (3.3 KB) - added by Imarok 18 months ago.
changes noted above + revert black player color change, because of incompatibility with diplomacy window

Download all attachments as: .zip

Change History (65)

comment:1 Changed 7 years ago by Ross Bearman

I've attached a proposal for the new colours, I'd be happy to go ahead and implement these if there aren't any objections.

Changed 7 years ago by Ross Bearman

Attachment: Recolouring.jpg added

Proposed recolouring.

comment:2 Changed 7 years ago by Philip Taylor

comment:3 Changed 7 years ago by Ilya Radchenko

Why not change the shape of the resource marker as well? So that if some colors are similar, the shape would still distinguish them. Maybe an open circle, triangle, star, or a plus.

comment:4 in reply to:  3 Changed 7 years ago by Ben Brian

Replying to knownasilya:

Why not change the shape of the resource marker as well? So that if some colors are similar, the shape would still distinguish them. Maybe an open circle, triangle, star, or a plus.

There were even suggestions to use small pixel art, maybe a tree shape for forests (large clumps of trees), a grey rock for stone mines, etc.

comment:5 Changed 7 years ago by Ilya Radchenko

How are the icons implemented? Are they loaded in from external sources or created with SVG or something? I'm looking through the source, found some xml, but cant find the files they refer to.

Last edited 7 years ago by Ilya Radchenko (previous) (diff)

comment:6 in reply to:  5 Changed 7 years ago by Ben Brian

Recent changes: [11197] and [11202]

Replying to knownasilya:

How are the icons implemented? Are they loaded in from external sources or created with SVG or something? I'm looking through the source, found some xml, but cant find the files they refer to.

We don't yet have icons on the minimap, all entities are marked with a large point. The minimap renderer will need to be extended to display pixel art for resources. I think the format should be PNG like all our other textures.

comment:7 Changed 7 years ago by jjalexander

Hi, how can the minimap renderer be expanded? Where is the code?

comment:8 Changed 7 years ago by ravenheart

In the proposed recoloring, Wood color is too similar to Stone. There's a block of stone between some wood a bit northwest of the orange player, and it's difficult to tell which is which. Also, the blue player has become too similar to water, and it seems it would be quite difficult to spot blue ships on the ocean.

Changed 6 years ago by Erik Johansson

Attachment: minimap.jpg added

Current (24th June 2012) state of the minimap

comment:9 Changed 6 years ago by Erik Johansson

Added an image showing the current state of the minimap colors on a couple of different maps as they have been somewhat improved since the ticket was created. There's still room for improvement though :)

comment:10 in reply to:  8 Changed 6 years ago by Ben Brian

Replying to jjalexander:

Hi, how can the minimap renderer be expanded? Where is the code?

See CMiniMap in source/gui/MiniMap.cpp for the rendering code.

comment:11 Changed 6 years ago by michael

One thing that definitely needs improved is the "layer" or "order" upon which different items are displayed. E.g., border lines should render above trees, instead of being occluded by trees. But that may be for another ticket.

Changed 3 years ago by Sergey Kushnirenko

comment:12 Changed 3 years ago by Sergey Kushnirenko

Summary: Player and resource colors conflict on minimap[PATCH] Player and resource colors conflict on minimap

comment:13 Changed 3 years ago by Sergey Kushnirenko

Cc: DalerankN8@… added
Keywords: review patch added
Milestone: BacklogAlpha 20

comment:14 Changed 3 years ago by Sergey Kushnirenko

Cc: DalerankN8@… added
Keywords: review patch added
Milestone: BacklogAlpha 20

comment:15 Changed 3 years ago by Niek

In Github Millennium A.D. started using a new color scheme that's based on dalerank's patch but also includes own testings and modifications. If desired I can make a few screenshots and a patch for SVN.

Changed 3 years ago by Niek

Attachment: MillenniumAD colors.png added

Per elexis' request: a few screenshots. Note that the Millennium A.D. color scheme aims to look more natural (and less neon-like)

Changed 3 years ago by Niek

And on Volcanic Lands

comment:16 Changed 3 years ago by elexis

Component: Core engineUI & Simulation
Keywords: minimap review removed

Changing the color of metal to white/gray is not good, since stone is gray too. It should be visible on first sight where the map has metal mines. (Sometimes metal mines are not visible on the minimap is there is a tree in the same coordinate, that should be addressed somewhere sometime too). It will never be perfectly possible to address all issues since ground textures can have arbitrary colors.

Giving the player a slightly darker orange won't help much.

Changing the colors a bit might make sense though.

Changed 3 years ago by Niek

Attachment: 1000ad15022016.png added

New fauna and metal mine colors in 1,000 A.D.

comment:17 Changed 3 years ago by elexis

Milestone: Alpha 20Alpha 21

Changed 3 years ago by Niek

Attachment: minimap_color.zip added

Color scheme (as of 31-03) in Millennium A.D. moved to a separate mod for testing

comment:18 Changed 3 years ago by Lionkanzen

Niektb's color scheme is promising, but need tested over different maps.

Changed 3 years ago by Niek

Attachment: minimap_color (v2).zip added

Improved metal mine color (and swapped with the bushes)

comment:19 Changed 3 years ago by Niek

My current bush color is maybe a bit too vibrant, but I would like to hear your opinion guys.

comment:20 Changed 3 years ago by elexis

Keywords: review added

Changed 3 years ago by Niek

Attachment: Minimap current state.png added

This is the current state of the mod

Changed 3 years ago by Niek

Attachment: minimap_color (v3).zip added

And the updated files

Changed 3 years ago by stanislas69

Attachment: 763.diff added

Patch of the above zip

comment:21 Changed 3 years ago by elexis

Keywords: review removed

Thanks for continuing this ticket.

Did the diff reveal an easteregg in the zip (description)? :P

The lighter stone mine color seems like a good change.

Don't like the orange and purple player color change. Too few color/contrast difference. Animals are too pink, not appealing to me. Metal is the most important resource and should be really obvious, but I feel the patch made it less noticeable. The black player is darker in your patch, but that doesn't really fix the issue of being invisible on maps like Volcanic Lands (nor is that issue fixable at all when using something black).


After all I'm not sure if it is worthy to change the player and resource colors (besides the stone maybe), at least in the proposed ways. No matter how it will change, one can argue the color distance is not big enough. The set of colors is limited, especially since the colors of the players are equidistant, so there is not much remaining to pick. Also we don't want people to relearn the minimap colors.


Alternatively we could add a border around the resource colors, so they can be distinguished from the playercolors that way.

comment:22 Changed 3 years ago by Niek

You skipped a few colors. What do you think of the new bush colors? They conflict less with the orange player.

Agreed with the reduced visibility of the metal mines. In earlier versions I had pink as metal mine (which is clearly noticeable). What do you think if that? (And then the fauna could be orange color (which is currently used as metal mine color))

I'm pretty sure that it's already a nice improvement on vanilla, and the argument of that we don't want people to relearn the colors: meh. It only takes a few games to get completely used to it.

comment:23 Changed 3 years ago by elexis

I don't mind if flora and fauna have the same color, but I don't like the proposed pink :P I'd commit the new stone color, other than that not really convinced.

Besides changing the colors directly or using multiple colors for resources and a single color for players, we could also allow players to change the colors in the config file or a new options tab. Not sure if it's worth the effort though, just an idea.

comment:24 Changed 2 years ago by elexis

Milestone: Alpha 21Alpha 22

Feature freeze in 2 days.

comment:25 Changed 23 months ago by Grugnas

Last edited 23 months ago by Grugnas (previous) (diff)

Changed 23 months ago by Grugnas

Attachment: minicolors.patch added

Resources recolor and Yellow Player recolor (it is kinda golden now, darker than the original in order to make a wider gap between metal and the player units, expecially while blinking)

comment:26 Changed 23 months ago by Grugnas

Keywords: review added

http://i.imgur.com/KciJHiH.jpg

Last edited 23 months ago by Grugnas (previous) (diff)

comment:27 Changed 23 months ago by fatherbushido

Thanks Grugnas! I guess niektb will get info about that ticket, he can give you his input!

comment:28 Changed 23 months ago by Niek

What did you base your patch on? My previous work or the current state on SVN? Could you also upload a few minimaps from different biomes?

comment:29 Changed 23 months ago by Grugnas

I took your archivie from the forum containing resources templates and player data files saving me a lot of time looking for the right files, thank you for this. http://i.imgur.com/u0uMQMQ.png Here you go with the screenshots, I think that in this way every resource is very visible, the only compromise is that fruit and animals have same color. Instead of getting food, you women could be the food for tigers :P

Last edited 23 months ago by Grugnas (previous) (diff)

comment:30 Changed 20 months ago by elexis

Milestone: Alpha 22Work In Progress

Moving to the Work In Progress milestone, since there is a patch asking for feedback, but since it is not strictly bound to a specific release.

Changed 19 months ago by Niek

Attachment: New minimap.png added

Changed 19 months ago by Niek

Attachment: minimap_color.2.zip added

New version following last week's discussion

Changed 19 months ago by Niek

Attachment: minimap_color.patch added

An as a patch too

Changed 19 months ago by Niek

Attachment: minimap_color.2.patch added

Shouldn't revert older commits

comment:31 Changed 19 months ago by elexis

Description: modified (diff)
Keywords: simple removed
Milestone: Work In ProgressAlpha 22
Priority: If Time PermitsNice to Have

Changed 19 months ago by Niek

Attachment: minimap_colors.patch added

Evil spaces

comment:32 Changed 19 months ago by Grugnas

Personally speaking: I like the slightly brighter green but i fear that, especially territory borders, are harder to distinguish (i tested the colors with the Red Sea). I don't like the blue (maybe because the current blue is quite vivid and because it is my favorite color). I don't like the yellow because it is too dark now while imho the yellow in my patch looks quite good. I'd tweak red in favor of a more vivid red (in forest biome the current red looks a bit dark and perhaps a vivid red is good looking and would stand out from environment even more). The black is too dark, perhaps a middle way between the current black and the proposed black. Probably i like more the current orange. The animals look nicely with the proposed light green. Metal can't be pink because it should be really easy to notice on the minimap. While animals are easy to notice on the minimap because they are grouped, on the other hand metal mine is hard to distinguish as single dot and this is the reason why i still prefer the bright yellow in my patch.

Changed 18 months ago by elexis

Attachment: diplo_screen.jpg added

Changed 18 months ago by elexis

Attachment: gamesetup.jpg added

Changed 18 months ago by elexis

Attachment: mainland.jpg added

Changed 18 months ago by elexis

Attachment: volcano.jpg added

comment:33 Changed 18 months ago by elexis

The yellow change seems ok, might be ok a tiny bit brighter as Grugnas proposes, but idc. Just want to stress that I agree the current yellow in svn is too bright.

The black color is too dark, the playername can't be seen anymore in the diplomacy screen. Blue seems just a bit too dark for the same reason. https://trac.wildfiregames.com/raw-attachment/ticket/763/diplo_screen.jpg

On volcano the current black has a camouflage effect, but that's not really better with the proposed patch and a won't fix I guess: https://trac.wildfiregames.com/raw-attachment/ticket/763/gamesetup.jpg

The other color seem ok to me before and after. https://trac.wildfiregames.com/raw-attachment/ticket/763/volcano.jpg

But what I find really bad is that metal mines have the same colors as metal mines. Metal mines are the most important resource on most maps and the places players fight for.

With the patch, it's harder to see metal mines on the minimap than before if there are berries. You could swap the berry and metal color though if you find these colors visually appealing. https://trac.wildfiregames.com/raw-attachment/ticket/763/mainland.jpg

The colors should become user configurable, so we don't have to impose these colors on each other.

comment:34 Changed 18 months ago by Niek

Metal mines have the same color as metal mines? Of course they have! :P

comment:35 Changed 18 months ago by Lionkanzen

That's is a issue, I understand if the game have better differentiated like other games, but isn't the case. In minimap and outside the metal isn't easy to differentiate.

comment:36 Changed 18 months ago by Imarok

It should be rgb and not bgr for metal

Changed 18 months ago by Imarok

Attachment: screenshot0072.png added

yellow metal

comment:37 Changed 18 months ago by Imarok

what about r="155" g="204" b="102" for metal mines?

https://trac.wildfiregames.com/raw-attachment/ticket/763/screenshot0072.png

comment:38 Changed 18 months ago by Imarok

best result I got, with changing metal and berries color: http://i.imgur.com/WICUgLW.png berries are lime, fauna brown and metal mines orange-yellowish

Changed 18 months ago by Imarok

Attachment: 763_minimap_colors.patch added

changes noted above + revert black player color change, because of incompatibility with diplomacy window

comment:39 Changed 18 months ago by Niek

And the fauna is pink now, right?

comment:40 Changed 18 months ago by Imarok

yes

comment:41 Changed 18 months ago by Imarok

Owner: set to Imarok
Resolution: fixed
Status: newclosed

In 19819:

Improve minimap colors

Patch by niektb and Grugnas. Reviewed by elexis. Fixes #763.

comment:42 Changed 18 months ago by Imarok

Keywords: review removed
Note: See TracTickets for help on using tickets.