Changes between Version 10 and Version 11 of SubmittingPatches

Timestamp:

Oct 18, 2013, 1:26:16 AM (11 years ago)

Author:

Erik Johansson

Comment:

--

SubmittingPatches

@@ -11 +11 @@
  * One of the core developers should then review it and maybe suggest some changes.
  * When it's considered okay, they should commit it to SVN.
- * If you don't hear anything within a reasonable time period (maybe a week or two), feel free to post a reminder on the [http://www.wildfiregames.com/forum/index.php?showforum=312 forum]. Some patches take longer to review due to low priority, high complexity, or special knowledge required to review it. We appreciate your patience and all contributions. Also, it's a good idea if you take some time to review patches yourself as well. Not only will this help speed things up as bugs and ways to improve your code can be found before a team member has had time to look at the patch, it's also a chance for you to become more familiar with the code and the coding conventions.
+ * If you don't hear anything within a reasonable time period (maybe a week or two), feel free to post a reminder on the [http://www.wildfiregames.com/forum/index.php?showforum=312 forum]. Some patches take longer to review due to low priority, high complexity, or special knowledge required to review it. We appreciate your patience and all contributions.
  * For more "controversial" changes and gameplay features, it's a good idea to create a topic on the forum anyway, to get as much feedback as possible from the community.
+ * Also, it's a good idea if you take some time to review patches yourself as well. Not only will this help speed things up as bugs and ways to improve your code can be found before a team member has had time to look at the patch, it's also a chance for you to become more familiar with the code and the coding conventions. Even just downloading/applying the patch and compiling it and testing if it does as it's supposed to is highly valuable. (Maybe the developer only has access to Linux, and you're on Windows or Mac, so even just testing to see if it compiles can be a good thing.) You don't have to know all the code to be able to review patches.
+
 
 You must agree that it is your own work (or else make it clear where it came from) and agree to licensing any code as [http://www.opensource.org/licenses/GPL-2.0 GPL 2+] (or in some cases [http://www.opensource.org/licenses/mit-license.php MIT], especially for code in `lib/` - check the existing copyright headers on the source files you edit) and data files as [http://creativecommons.org/licenses/by-sa/3.0/ CC-BY-SA 3.0].