Changes between Version 6 and Version 7 of SubmittingPatches


Ignore:
Timestamp:
Oct 5, 2011, 1:35:23 AM (13 years ago)
Author:
historic_bruno
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • SubmittingPatches

    v6 v7  
    77 * Make sure you've updated to the latest version of the code (and merged in your own changes).
    88 * Create a patch, with `svn diff` (or the equivalent "create patch" feature in TortoiseSVN).
    9  * Attach it to a Trac ticket (an existing ticket if there's a relevant one, else a new one), and add "review" to the keywords list. (The keyword makes it show up on [query:status=new|assigned|reopened&keywords=~review this query].)
     9 * Attach it to a Trac ticket (an existing ticket if there's a relevant one, else a new one), prefix the ticket '''Summary''' with "[PATCH]", set the ticket '''Milestone''' to the current release, and add "review" to the '''Keywords''' list. (The keyword makes it show up on [query:status=new|assigned|reopened&keywords=~review this query].)
    1010 * One of the core developers should then review it and maybe suggest some changes.
    1111 * When it's considered okay, they should commit it to SVN.
    1212 * If you don't hear anything within a reasonable time period (maybe a week or two), feel free to post a reminder on the [http://www.wildfiregames.com/forum/index.php?showforum=312 forum].
    1313
    14 The person submitting the patch must agree that it is their own work (or else make it clear where it came from), and agree to licensing the work as BSD or GPL (we're not yet quite sure which we want...)
     14The person submitting the patch must agree that it is their own work (or else make it clear where it came from) and agree to licensing the work as GPL.