Ticket #3205: t3205_enlighten_too_dark_chat_colors_a18.patch

binaries/data/mods/public/gui/common/color.js

@@ +1 @@
+// Ensure `value` is between 0 and 1.
+function clampColorValue(value)
+{
+    return Math.abs(1 - Math.abs(value - 1));
+}
+
+function rgbToHsl(r, g, b)
+{
+    r /= 255;
+    g /= 255;
+    b /= 255;
+    var max = Math.max(r, g, b), min = Math.min(r, g, b);
+    var h, s, l = (max + min) / 2;
+
+    if (max == min)
+        h = s = 0; // achromatic
+    else
+    {
+        var d = max - min;
+        s = l > 0.5 ? d / (2 - max - min) : d / (max + min);
+        switch (max)
+        {
+            case r: h = (g - b) / d + (g < b ? 6 : 0); break;
+            case g: h = (b - r) / d + 2; break;
+            case b: h = (r - g) / d + 4; break;
+        }
+        h /= 6;
+    }
+
+    return [h, s, l];
+}
+
+function hslToRgb(h, s, l)
+{
+    function hue2rgb(p, q, t)
+    {
+        if (t < 0) t += 1;
+        if (t > 1) t -= 1;
+        if (t < 1/6) return p + (q - p) * 6 * t;
+        if (t < 1/2) return q;
+        if (t < 2/3) return p + (q - p) * (2/3 - t) * 6;
+        return p;
+    }
+
+    [h, s, l] = [h, s, l].map(clampColorValue);
+    var r, g, b;
+
+    if (s == 0)
+        r = g = b = l; // achromatic
+    else {
+        var q = l < 0.5 ? l * (1 + s) : l + s - l * s;
+        var p = 2 * l - q;
+        r = hue2rgb(p, q, h + 1/3);
+        g = hue2rgb(p, q, h);
+        b = hue2rgb(p, q, h - 1/3);
+    }
+
+    return [r, g, b].map(function (n) Math.round(n * 255));
+}
+ No newline at end of file

binaries/data/mods/public/gui/gamesetup/gamesetup.js

@@ -1717 +1717 @@
         var mapData = loadMapData(mapName);
         var mapSettings = (mapData && mapData.settings ? mapData.settings : {});
         var pData = mapSettings.PlayerData ? mapSettings.PlayerData[player] : {};
         var pDefs = g_DefaultPlayerData ? g_DefaultPlayerData[player] : {};
 
-        color = rgbToGuiColor(getSetting(pData, pDefs, "Colour"));
++       color = getSetting(pData, pDefs, "Colour");
+
++       // enlighten colors to improve readability
++       var [h, s, l] = rgbToHsl(color.r, color.g, color.b);
++       var [r, g, b] = hslToRgb(h, s, Math.max(0.7, l));
++       color = rgbToGuiColor({"r": r, "g": g, "b": b});
     }
 
     var formatted;
     switch (msg.type)
     {

binaries/data/mods/public/gui/gamesetup/gamesetup.xml

@@ -1 +1 @@
 <?xml version="1.0" encoding="utf-8"?>
 
 <objects>
 
+    <script file="gui/common/color.js"/>
     <script file="gui/common/network.js"/>
     <script file="gui/common/functions_civinfo.js"/>
     <script file="gui/common/functions_global_object.js"/>
     <script file="gui/common/functions_utility.js"/>
     <script file="gui/gamesetup/gamesetup.js"/>

binaries/data/mods/public/gui/lobby/lobby.js

@@ -232 +232 @@
     if (role && caller == "lobbylist")
     {
         // Make the role uppercase.
         role = role.charAt(0).toUpperCase() + role.slice(1);
         if (role == "Moderator")
-            role = '[color="0 125 0"]' + translate(role) + '[/color]';
+            role = '[color="0 219 0"]' + translate(role) + '[/color]';
     }
     else
         role = "";
 
     Engine.GetGUIObjectByName("usernameText").caption = user;
@@ -392 +392 @@
         if(!filterGame(g))
         {
             // 'waiting' games are highlighted in orange, 'running' in red, and 'init' in green.
             let name;
             if (g.state == 'init')
-                name = '[color="0 125 0"]' + g.name + '[/color]';
+                name = '[color="0 219 0"]' + g.name + '[/color]';
             else if (g.state == 'waiting')
                 name = '[color="255 127 0"]' + g.name + '[/color]';
             else
-                name = '[color="255 0 0"]' + g.name + '[/color]';
+                name = '[color="219 0 0"]' + g.name + '[/color]';
             list_name.push(name);
             list_ip.push(g.ip);
             list_mapName.push(translate(g.niceMapName));
             list_mapSize.push(translatedMapSize(g.mapSize));
             let idx = g_mapTypes.indexOf(g.mapType);
@@ -450 +450 @@
     case "away":
         color = "229 76 13";
         status = translate("Away");
         break;
     case "available":
-        color = "0 125 0";
+        color = "0 219 0";
         status = translate("Online");
         break;
     case "offline":
         color = "0 0 0";
         status = translate("Offline");
@@ -1015 +1015 @@
     // First create the color in RGB then HSL, clamp the lightness so it's not too dark to read, and then convert back to RGB to display.
     // The reason for this roundabout method is this algorithm can generate values from 0 to 255 for RGB but only 0 to 100 for HSL; this gives
     // us much more variety if we generate in RGB. Unfortunately, enforcing that RGB values are a certain lightness is very difficult, so
     // we convert to HSL to do the computation. Since our GUI code only displays RGB colors, we have to convert back.
     var [h, s, l] = rgbToHsl(hash >> 24 & 0xFF, hash >> 16 & 0xFF, hash >> 8 & 0xFF);
-    return hslToRgb(h, s, Math.max(0.4, l)).join(" ");
+    return hslToRgb(h, s, Math.max(0.7, l)).join(" ");
 }
 
 function repeatString(times, string) {
     return Array(times + 1).join(string);
 }
@@ -1043 +1043 @@
 function clampColorValue(value)
 {
     return Math.abs(1 - Math.abs(value - 1));
 }
 
-// See http://stackoverflow.com/questions/2353211/hsl-to-rgb-color-conversion
-function rgbToHsl(r, g, b)
-{
-    r /= 255;
-    g /= 255;
-    b /= 255;
-    var max = Math.max(r, g, b), min = Math.min(r, g, b);
-    var h, s, l = (max + min) / 2;
-
-    if (max == min)
-        h = s = 0; // achromatic
-    else
-    {
-        var d = max - min;
-        s = l > 0.5 ? d / (2 - max - min) : d / (max + min);
-        switch (max)
-        {
-            case r: h = (g - b) / d + (g < b ? 6 : 0); break;
-            case g: h = (b - r) / d + 2; break;
-            case b: h = (r - g) / d + 4; break;
-        }
-        h /= 6;
-    }
-
-    return [h, s, l];
-}
-
-function hslToRgb(h, s, l)
-{
-    function hue2rgb(p, q, t)
-    {
-        if (t < 0) t += 1;
-        if (t > 1) t -= 1;
-        if (t < 1/6) return p + (q - p) * 6 * t;
-        if (t < 1/2) return q;
-        if (t < 2/3) return p + (q - p) * (2/3 - t) * 6;
-        return p;
-    }
-
-    [h, s, l] = [h, s, l].map(clampColorValue);
-    var r, g, b;
-
-    if (s == 0)
-        r = g = b = l; // achromatic
-    else {
-        var q = l < 0.5 ? l * (1 + s) : l + s - l * s;
-        var p = 2 * l - q;
-        r = hue2rgb(p, q, h + 1/3);
-        g = hue2rgb(p, q, h);
-        b = hue2rgb(p, q, h - 1/3);
-    }
-
-    return [r, g, b].map(function (n) Math.round(n * 255));
-}
-
 (function () {
 function hexToRgb(hex) {
     return parseInt(hex.slice(0, 2), 16) + "." + parseInt(hex.slice(2, 4), 16) + "." + parseInt(hex.slice(4, 6), 16) + ".";
 }
 function r(times, hex) {

binaries/data/mods/public/gui/lobby/lobby.xml

@@ -1 +1 @@
 <?xml version="1.0" encoding="utf-8"?>
 
 <objects>
     <script file="gui/common/functions_global_object.js"/>
     <script file="gui/common/functions_utility.js"/>
+    <script file="gui/common/color.js"/>
     <script file="gui/common/timer.js"/>
     <script file="gui/common/music.js"/>
-
     <script file="gui/lobby/lobby.js"/>
 
     <object type="image" style="ModernWindow" size="0 0 100% 100%" name="lobbyWindow">
 
         <object style="ModernLabelText" type="text" size="50%-128 0%+4 50%+128 36">