Ticket #3252: t3252_fix_trade_tooltip.patch

binaries/data/mods/public/gui/session/utility_functions.js

@@ -120 +120 @@
 /**
  * Returns a message with the details of the trade gain.
  */
 function getTradingTooltip(gain)
 {
+
+    var playerID = Engine.GetPlayerID();
+    var simState = GetSimState();
+    
     var gainString = gain.traderGain;
     if (gain.market1Gain && gain.market1Owner == gain.traderOwner)
         gainString += translate("+") + gain.market1Gain;
     if (gain.market2Gain && gain.market2Owner == gain.traderOwner)
         gainString += translate("+") + gain.market2Gain;
 
     var tooltip = sprintf(translate("%(gain)s (%(player)s)"), {
         gain: gainString,
-        player: translate("you")
+        player: gain.traderOwner == playerID ? translate("You") : simState.players[gain.traderOwner].name
     });
 
     if (gain.market1Gain && gain.market1Owner != gain.traderOwner)
         tooltip += translate(", ") + sprintf(translate("%(gain)s (%(player)s)"), {
             gain: gain.market1Gain,
-            player: sprintf(translate("player %(name)s"), { name: gain.market1Owner })
+            player: gain.market1Owner == playerID ? translate("You") : simState.players[gain.market1Owner].name
         });
     if (gain.market2Gain && gain.market2Owner != gain.traderOwner)
         tooltip += translate(", ") + sprintf(translate("%(gain)s (%(player)s)"), {
             gain: gain.market2Gain,
-            player: sprintf(translate("player %(name)s"), { name: gain.market2Owner })
+            player: gain.market2Owner == playerID ? translate("You") : simState.players[gain.market2Owner].name
         });
 
     return tooltip;
 }