[PATCH] getTradingTooltip is wrong

[elexis]

The tooltip of the trade cart always says that the current player / observer profits, since it always uses the hardcoded string "you":

	var tooltip = sprintf(translate("%(gain)s (%(player)s)"), {
		gain: gainString,
		player: translate("you")
	});

It basically acts as if one could only click the own trade carts. A simple check is missing. If the trade cart belongs to another player than that playername should be displayed instead.

[elexis]

The other problem with this tooltip is it has "player X" hardcoded and doesn't use (nor attempt to use) the actual playername:

player: sprintf(translate("player %(name)s"), { name: gain.market1Owner })

So this second bug is not related to #3253.

[elexis]

Fixes the two issues described above. (Attempts to use the correct playername, and succeeds if #3253 is committed).

[sanderd17]

In 16659:

Fix player names in trade tooltips. Patch by elexis. Fixes #3252

[elexis]

The string "You" will now only appear in singleplayer, in order to prevent confusion with players who might call themselves "You".

[leper]

In 16661:

Use the actual player name in MP. Patch by elexis. Refs #3252.