Ticket #4151: 4151-remove-sendgetratinglist-rev1.patch

binaries/data/mods/public/gui/lobby/lobby.js

@@ -147 +147 @@
                 }),
                 "isSpecial": true
             });
-            Engine.SendGetRatingList();
         },
         "leave": msg => {
             addChatMessage({

source/lobby/IXmppClient.h

@@ -33 +33 @@
     virtual void recv() = 0;
     virtual void SendIqGetGameList() = 0;
     virtual void SendIqGetBoardList() = 0;
-    virtual void SendIqGetRatingList() = 0;
     virtual void SendIqGetProfile(const std::string& player) = 0;
     virtual void SendIqGameReport(ScriptInterface& scriptInterface, JS::HandleValue data) = 0;
     virtual void SendIqRegisterGame(ScriptInterface& scriptInterface, JS::HandleValue data) = 0;

source/lobby/XmppClient.cpp

@@ -299 +299 @@
 }
 
 /**
- * Request the rating data from the server.
- */
-void XmppClient::SendIqGetRatingList()
-{
-    glooxwrapper::JID xpartamuppJid(m_xpartamuppId);
-
-    // Send IQ
-    BoardListQuery* b = new BoardListQuery();
-    b->m_Command = "getratinglist";
-    glooxwrapper::IQ iq(gloox::IQ::Get, xpartamuppJid);
-    iq.addExtension(b);
-    DbgXMPP("SendIqGetRatingList [" << tag_xml(iq) << "]");
-    m_client->send(iq);
-}
-
-/**
  * Send game report containing numerous game properties to the server.
  *
  * @param data A JS array of game statistics

source/lobby/XmppClient.h

@@ -63 +63 @@
     void recv();
     void SendIqGetGameList();
     void SendIqGetBoardList();
-    void SendIqGetRatingList();
     void SendIqGetProfile(const std::string& player);
     void SendIqGameReport(ScriptInterface& scriptInterface, JS::HandleValue data);
     void SendIqRegisterGame(ScriptInterface& scriptInterface, JS::HandleValue data);

source/lobby/scripting/JSInterface_Lobby.cpp

@@ -41 +41 @@
     scriptInterface.RegisterFunction<void, &JSI_Lobby::DisconnectXmppClient>("DisconnectXmppClient");
     scriptInterface.RegisterFunction<void, &JSI_Lobby::SendGetGameList>("SendGetGameList");
     scriptInterface.RegisterFunction<void, &JSI_Lobby::SendGetBoardList>("SendGetBoardList");
-    scriptInterface.RegisterFunction<void, &JSI_Lobby::SendGetRatingList>("SendGetRatingList");
     scriptInterface.RegisterFunction<void, std::wstring, &JSI_Lobby::SendGetProfile>("SendGetProfile");
     scriptInterface.RegisterFunction<void, JS::HandleValue, &JSI_Lobby::SendRegisterGame>("SendRegisterGame");
     scriptInterface.RegisterFunction<void, JS::HandleValue, &JSI_Lobby::SendGameReport>("SendGameReport");
@@ -134 +133 @@
     g_XmppClient->SendIqGetBoardList();
 }
 
-void JSI_Lobby::SendGetRatingList(ScriptInterface::CxPrivate* UNUSED(pCxPrivate))
-{
-    if (!g_XmppClient)
-        return;
-    g_XmppClient->SendIqGetRatingList();
-}
-
 void JSI_Lobby::SendGetProfile(ScriptInterface::CxPrivate* UNUSED(pCxPrivate), const std::wstring& player)
 {
     if (!g_XmppClient)

source/lobby/scripting/JSInterface_Lobby.h

@@ -38 +38 @@
     void DisconnectXmppClient(ScriptInterface::CxPrivate* pCxPrivate);
     void SendGetGameList(ScriptInterface::CxPrivate* pCxPrivate);
     void SendGetBoardList(ScriptInterface::CxPrivate* pCxPrivate);
-    void SendGetRatingList(ScriptInterface::CxPrivate* pCxPrivate);
     void SendGetProfile(ScriptInterface::CxPrivate* pCxPrivate, const std::wstring& player);
     void SendGameReport(ScriptInterface::CxPrivate* pCxPrivate, JS::HandleValue data);
     void SendRegisterGame(ScriptInterface::CxPrivate* pCxPrivate, JS::HandleValue data);