[PATCH] Remove deprecated SendGetRatingList

[elexis]

Since r16964, the SendGetRatingList calls from lobby.js are ignored on the server side (XpartaMupp.py) as they were too spammy.

The other remains in XmppClient.cpp and lobby.js, potentially StanzaExtensions.cpp should be removed as well.

[sbirmi]

Again.. looks like a straightforward change. Might be obvious to others but I went looking. The leaderboard does not rely on rating list. With the patch I'm going to attach, I am removing SendGetRatingList() from the JSInterface_Lobby as well (which calls XmppClient's code which is also removed). Invocation from lobby.js is also removed.

There is still code in EcheL0n.py:sendRatingList() which seems to reply to rating list requests. Should that be kept?

[sbirmi]

remove SendGetRatingList

[elexis]

Thanks for your patches! Please don't forget to add your nickname and perhaps realname to the programming.json file, so we have you in the contributor list.

[sbirmi]

adding name to programming.json

[elexis]

In 19463:

Remove SendGetRatingList lobby function which is deprecated and ignored serverside since rP16964 because it caused performance issues and therefore shouldn't be used anymore.

Fixes #4151
Patch by: sbirmi

[elexis]

Thanks for the patch and sorry that it took so long again!

[elexis]

There is still code in EcheL0n.py:sendRatingList() which seems to reply to rating list requests. Should that be kept?

Yes, it must be kept as that request is sent from XPartaMupp.

However (unrelated to this client side change), there should be a check that this request is sent by a trustworthy client. I've discussed this with scythetwirler on irc yesterday and we think that a moderator check should be sufficient (as opposed to adding a command line argument for the name of the bot).