Opened 12 years ago

Closed 9 years ago

#1191 closed enhancement (wontfix)

[PATCH] 'esc' key mapped to toggleMenu()

Reported by: Ilya Radchenko Owned by:
Priority: Nice to Have Milestone:
Component: Core engine Keywords: patch
Cc: Patch:

Description

At the moment the 'esc' key is useless during the game session. Making the 'esc' key to toggle the menu or to pause the game would be very beneficial.

Attachments (1)

Patch1191.patch (1.4 KB ) - added by Matt Doerksen 12 years ago.
[PATCH] Pauses the game when Esc is pressed and brings up the menu. Unpauses and hides the menu when pressed a second time. Works in conjunction with the pause key.

Download all attachments as: .zip

Change History (12)

comment:1 by Ilya Radchenko, 12 years ago

Just found out that 'pause' key pauses. Also, even though the 'esc' key is mapped, it doesn't work.

by Matt Doerksen, 12 years ago

Attachment: Patch1191.patch added

[PATCH] Pauses the game when Esc is pressed and brings up the menu. Unpauses and hides the menu when pressed a second time. Works in conjunction with the pause key.

comment:2 by Matt Doerksen, 12 years ago

Keywords: review added
Milestone: BacklogAlpha 10
Owner: set to Matt Doerksen
Status: newassigned
Summary: 'esc' key mapped to toggleMenu()[PATCH] 'esc' key mapped to toggleMenu()

comment:3 by Kieran P, 12 years ago

Keywords: patch added; menu pause shortcuts esc removed

comment:4 by historic_bruno, 12 years ago

Related problem: #1291

comment:5 by Kieran P, 12 years ago

Keywords: patch, review → patch review
Milestone: Alpha 10Alpha 11

comment:6 by historic_bruno, 12 years ago

I don't think Esc should pause the game, we already have a separate hotkey for that (Pause by default). The expected behavior of Esc is that it should cancel the last action or close a recently opened menu item. In that sense it shouldn't toggle either, but simply close the menu if it's open (I don't think it even needs to be a configurable hotkey - it's a standard UI hotkey).

Also my preference would be to tie these really common "global" hotkeys into the GUI engine itself if feasible.

Last edited 12 years ago by historic_bruno (previous) (diff)

comment:7 by historic_bruno, 12 years ago

Keywords: review removed

comment:8 by Kieran P, 12 years ago

Milestone: Alpha 11Backlog

comment:9 by historic_bruno, 10 years ago

Owner: Matt Doerksen removed
Status: assignednew

comment:10 by Stan, 10 years ago

Keywords: design added

comment:11 by historic_bruno, 9 years ago

Keywords: design removed
Milestone: Backlog
Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.