#1370 closed defect (fixed)
Implement defeat music
| Reported by: | vls | Owned by: | leper |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Alpha 11 |
| Component: | UI & Simulation | Keywords: | |
| Cc: | brian | Patch: |
Description (last modified by )
See attached screenshot
Attachments (1)
Change History (9)
by , 12 years ago
| Attachment: | 3.after defit.jpg added |
|---|
comment:1 by , 12 years ago
| Priority: | Release Blocker → Should Have |
|---|
comment:2 by , 12 years ago
| Cc: | added |
|---|---|
| Component: | Music & Sound FX → UI & Simulation |
| Description: | modified (diff) |
| Summary: | Unrecognized music type: defeat → Implement defeat music |
Defeat music isn't implemented as far as I know, the first message in the console is not an error, but a reminder to implement it :) This may be fixed as part of our planned sound system overhaul.
(The warning/error are separate, AI-related issues.)
comment:4 by , 12 years ago
| Priority: | Should Have → Nice to Have |
|---|
follow-up: 6 comment:5 by , 12 years ago
Is this error still occuring?
Defeat music (and victory music) should work as of r12020. Probably some call site used defeat (or global.music.states.defeat) instead of global.music.states.DEFEAT.
comment:6 by , 12 years ago
Replying to leper:
Is this error still occuring?
You have to play a civ that has defeat or victory music defined in the civ data file, like Romans, and then check the console after the game starts (it's a direct console output). The problem is there's no case in Music.storeTracks() to handle loading defeat or victory music. If it's trivial to fix, it may be worth doing short term, but eventually the music logic should be moved outside of JS per what used to be #961 :)
comment:8 by , 12 years ago
I went ahead and fixed it (I also changed the console logging to warnings, so that they show up in the logs).
Regarding #961: I think we should leave some of the music logic in JS, but we should move that out of the gui code as it doesn't fit there. We should probably reopen/create a new ticket for this task after the new sound manager is completed.
Hmm, does the defeat music not play at all?Doing a quick test I notice it does play, so it seems like a weird warning for an issue that doesn't exist (or rather: there might be a programming error, but it doesn't affect gameplay). Something to look into sure, but definitely not a release blocker.