Opened 12 years ago

Closed 12 years ago

#1390 closed defect (wontfix)

[PATCH] 'm_BoneMatrices' pointer was utilized before it was verified against nullptr (model.cpp)

Reported by: Echelon9 Owned by:
Priority: Should Have Milestone:
Component: Core engine Keywords:
Cc: philip Patch:

Description

A potential null pointer dereference, looks to have been introduced around the time of r11490.

Access occurs on the following line of model.cpp, which it outside the respective check if() statement: 

CMatrix3D boneMatrix = m_BoneMatrices[prop.m_Point->m_BoneIndex];

Proposed patch attached.

Attachments (1)

1390-null-ptr-dereference-m_BoneMatrices.patch​ (2.1 KB ) - added by Echelon9 12 years ago.
Proposed fix for m_BoneMatrices null pointer dereference

Download all attachments as: .zip

Change History (2)

by Echelon9, 12 years ago

Attachment: 1390-null-ptr-dereference-m_BoneMatrices.patch​ added

Proposed fix for m_BoneMatrices null pointer dereference

comment:1 by historic_bruno, 12 years ago

Keywords: review removed
Milestone: Alpha 10
Resolution: → wontfix
Status: new → closed

Won't fix because it would only cause a problem in an error condition (incorrectly initialized model).

Note: See TracTickets for help on using tickets.