[PATCH] Random maps should have random civilization by default

[fabio]

To make it truly random :)

[Matt Doerksen]

A couple of things regarding this patch:

1) Is there a constant defining the number of civilizations? Currently I'm using [code]

var civList = loadCivData(); var civCount = -1; start at -1 to offset the inclusion of "random" for each (var civName in civList) {

civCount++;

}

code but if there's a constant that would be better.

2) For random civilization selection I have this code:

[code] random civilization pre-selected, changeable before game civCount will be replaced if there is a constant for the # of civilizations pCiv.selected = Math.floor(Math.random()*civCount) + 1; randomized at game start, unchangeable before game pCiv.selected = 0; code

Like I've commented, the first option will randomly select a starting civilization, but it can be changed by the user. The second option forces the civilization to random and will only be generated once the game starts; the user will not be able to change it. Which option do people think is better?

[historic_bruno]

The UI shouldn't be random, I'm pretty sure what we want is just that "Random" civ be selected by default in random map setup but also changeable before the game starts.

[Matt Doerksen]

Updated patch to insert "Random" as the first civ for each player in a random game. It can be changed by the leader to whatever civilizations they want (if they choose).

[historic_bruno]

Thanks for the patch. I tested it, but it only chooses a random civ for player 1, even though it displays "Random" for all players in setup, the others stay in alphabetical order. Presumably the onSelectionChange event handler isn't being called as you expected (to avoid recursion) and the map settings aren't updated. It's probably a bad idea to try doing that in the GUI update (onGameAttributesChange is really just a GUI update).

A different solution would be to special case usage of g_DefaultPlayerData (loaded from player_defaults.json) or copy it specially for random maps, changing the default civ to "random". We don't have to worry about saving the player's choices if they change between scenario/random map types, eventually the game setup options will need persistent storage. Of course player settings should be preserved when switching between different random maps, the solution shouldn't break that.

Any other ideas? :)

[O.Davoodi]

Fixed in #12106.