Opened 12 years ago

Closed 11 years ago

#1519 closed defect (fixed)

Warning in actor viewer when previewing attack animations

Reported by: historic_bruno Owned by:
Priority: Should Have Milestone: Alpha 13
Component: Atlas editor Keywords:
Cc: Patch:

Description

Another symptom of actor viewer lacking player assignments (see #1499). Attack animations use the Attack component which tries to apply techs:

WARNING: GetPlayerByID: no player defined for id '0'
(0)@simulation/components/PlayerManager.js:28
QueryOwnerInterface(5,28)@simulation/helpers/Player.js:168
("Melee")@simulation/components/Attack.js:298 @(eval):1

Everything works because Attack handles this failure gracefully. I don't know if we should add proper player data to actor viewer's simulation (and keep it synced with the editor's simulation) or just squash the warning.

Change History (4)

comment:1 by historic_bruno, 12 years ago

Other random ideas:

  • Add some kind of global game option component, that allows turning off techs, territories, etc., and add the logic wherever these components would be used (more complicated but may be beneficial later when we want different game types) - in this case actor viewer could disable techs in its local simulation.
  • If we remove the GetPlayerByID warning, we should check every use of GetPlayerByID including indirect calls with QueryOwnerInterface and handle the return value properly (INVALID_ENTITY or null). But this is really just covering up the problem in actor viewer.

comment:2 by Kieran P, 12 years ago

Milestone: Alpha 11Alpha 12

comment:3 by Kieran P, 11 years ago

Milestone: Alpha 12Backlog

comment:4 by historic_bruno, 11 years ago

Milestone: BacklogAlpha 13
Resolution: fixed
Status: newclosed

The warning has been fixed.

Note: See TracTickets for help on using tickets.