Opened 12 years ago

Closed 9 years ago

Last modified 9 years ago

#1554 closed defect (fixed)

[PATCH] Actor Editor broken on OS X

Reported by: historic_bruno Owned by: trompetin17
Priority: Nice to Have Milestone: Alpha 20
Component: Atlas editor Keywords: wxwidgets
Cc: Patch:

Description

It opens behind other windows and there's no menu bar. Reproduced on 10.7.3 with wxOSX 2.9. Atlas works fine on the same system. There is also an error when it closes "can't open user configuration file".

Attachments (1)

1554.diff (899 bytes ) - added by trompetin17 9 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 by historic_bruno, 12 years ago

Keywords: wxwidgets added

comment:2 by wraitii, 10 years ago

Interestingly, if you replace line 320 of tools/atlas/GameInterface/GameLoop.cpp by

Atlas_StartWindow(L"ActorEditor");

and then start the scenario editor from inside the game, the menu bar appears and the actor editor seems to work correctly (with a crash when quitting).

comment:3 by Echelon9, 10 years ago

Confirming there are still issues with ActorEditor on OS X with r15789.

Running the debug build from commandline no windows or terminal output is given.

by trompetin17, 9 years ago

Attachment: 1554.diff added

comment:4 by trompetin17, 9 years ago

Keywords: review patch added
Milestone: BacklogAlpha 18
Owner: set to trompetin17
Status: newassigned
Summary: Actor Editor broken on OS X[PATCH] Actor Editor broken on OS X

Tested in yosemite my patch.

comment:5 by Echelon9, 9 years ago

Went to do a test build and my trunk copy of 0ad under Release is not building the AtlasUI.dylib? On OS X 10.9 with latest Xcode and Commandline Tools.

Force rebuilt libraries and updated workspaces first.

Is that being experienced by others? This is preventing me testing this patch.

comment:6 by trompetin17, 9 years ago

If you open the project in xcode, remember "edit Schema" for pyrogenesis, and add in "build tab" the project collada, atlasUI and actoreditor.

So when you compile pyrogenesis form xcode you are already compiling the other one.

Last edited 9 years ago by trompetin17 (previous) (diff)

comment:7 by Echelon9, 9 years ago

I build from the command line per http://trac.wildfiregames.com/wiki/BuildInstructions#OSX, and have done so for some time.

If it's stopped working for some reason "straight out of the box" then that is a bug that needs looking at on OS X.

comment:8 by Stan, 9 years ago

Milestone: Alpha 18Alpha 19

comment:9 by Itms, 9 years ago

Hello guys, it would be nice to do something with this patch. If it works, someone should commit it ASAP, if it doesn't we should backlog it for lack of progress. :)

comment:10 by Echelon9, 9 years ago

trompetin17's patch 1554.diff fixes the specific issue here for me on OS X, using latest trunk.

I would suggest commiting it, and resolving other refactors later on.

Last edited 9 years ago by Echelon9 (previous) (diff)

comment:11 by mimo, 9 years ago

Milestone: Alpha 19Alpha 20

pushing it as no activity lately

comment:12 by wraitii, 9 years ago

Resolution: fixed
Status: assignedclosed

In 17458:

Fix the actoreditor menu bar on OSX. Patch by trompetin17. Fixes #1554.

comment:13 by wraitii, 9 years ago

Keywords: review patch removed
Note: See TracTickets for help on using tickets.