Opened 12 years ago

Closed 10 years ago

Last modified 10 years ago

#1568 closed enhancement (fixed)

update bundled enet to 1.3.10

Reported by: fabio Owned by: ben
Priority: Should Have Milestone: Alpha 17
Component: Core engine Keywords:
Cc: Patch:

Description (last modified by fabio)

Bundled enet is 1.3.3, while upstream has 1.3.10.

Even better it could be removed from the bundled lib and force users to use the system enet (at least on unix) since distribution already provide it and keep updated.

Change History (7)

comment:1 by historic_bruno, 12 years ago

Milestone: Alpha 11Backlog

Please don't set every ticket to Alpha 11; unless you have a patch or release blocker bug, it should be set to Backlog.

I don't know why we bundle ENet though, since we don't modify the source. Probably it's best to clarify that before we remove it and discover it was really needed on some distro. Recent distros might have it, but what about older ones?

For now it's not a big deal since anyone who has system ENet can use the --with-system-enet build option.

in reply to:  1 comment:2 by fabio, 12 years ago

Replying to historic_bruno:

Please don't set every ticket to Alpha 11; unless you have a patch or release blocker bug, it should be set to Backlog.

No problem, it was not clear to me what the standard procedure was, I usually set to the latest and let developers downgrade it at their opinion.

I don't know why we bundle ENet though, since we don't modify the source. Probably it's best to clarify that before we remove it and discover it was really needed on some distro. Recent distros might have it, but what about older ones?

For now it's not a big deal since anyone who has system ENet can use the --with-system-enet build option.

comment:3 by fabio, 12 years ago

Description: modified (diff)
Summary: update bundled enet to 1.3.4update bundled enet to 1.3.5

in reply to:  1 comment:4 by fabio, 12 years ago

Replying to historic_bruno:

I don't know why we bundle ENet though, since we don't modify the source. Probably it's best to clarify that before we remove it and discover it was really needed on some distro. Recent distros might have it, but what about older ones?

I think that 0 A.D. historically bundled enet (as well as some other libraries). Support for using system libraries was later added to comply with Linux distributions. Specifically, support for system enet was added in r9574. 1.3 is probably packaged in any current unix distribution, older one can still install 1.3 alongside 1.2.

Last edited 11 years ago by fabio (previous) (diff)

comment:5 by fabio, 11 years ago

Description: modified (diff)
Summary: update bundled enet to 1.3.5update bundled enet to 1.3.10

comment:6 by ben, 10 years ago

Owner: set to ben
Resolution: fixed
Status: newclosed

In 15457:

Removes bundled ENet source. NOTE: system libenet (1.3) is now required on *nix, see BuildInstructions for updates. This change requires running update-workspaces. Fixes #1568.
Updates update-workspaces.sh and build-osx-libs.sh for this change.
Updates precompiled win32 ENet to 1.3.12, built with VC++ 2010, and moves it to libraries/win32, refs #864.

comment:7 by fabio, 10 years ago

Milestone: BacklogAlpha 17
Note: See TracTickets for help on using tickets.